From fb4f6e6290e8367e44028ad980081dad3797c102 Mon Sep 17 00:00:00 2001 From: Eyal Gruss Date: Sat, 25 May 2024 22:37:39 +0300 Subject: [PATCH] clarifiy that element capture is just for google chrome --- README.md | 2 +- script.js | 5 +---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index c877834..42dd9cd 100644 --- a/README.md +++ b/README.md @@ -5,7 +5,7 @@ Demo: https://eyaler.github.io/LordTubeMaster/#dQw4w9WgXcQ Note as of May 2024 this is only supported on *Chromium desktop* -For fullscreen zoom of output (by right-click), enable: `chrome://flags/#element-capture` +For fullscreen zoom of output (by right-click) in *Google Chrome*, enable: `chrome://flags/#element-capture`
diff --git a/script.js b/script.js index 2cb1cea..10aca99 100644 --- a/script.js +++ b/script.js @@ -1,6 +1,3 @@ -// Note as of May 2024 this is only supported on Chromium desktop -// For fullscreen zoom of output (by right-click), enable: chrome://flags/#element-capture - import { PoseLandmarker, FilesetResolver, @@ -234,7 +231,7 @@ async function capture() { const [track] = stream.getVideoTracks() track.addEventListener('ended', () => capture_started = false) try { - // Enable chrome://flags/#element-capture - this will also enable fullscreen zoom of output + // In Google Chrome, enable chrome://flags/#element-capture - this will enable fullscreen zoom of output // See: https://developer.chrome.com/docs/web-platform/element-capture // Note that pinch zoom pauses the stream: https://issuetracker.google.com/issues/337337168 const restrictionTarget = await RestrictionTarget.fromElement(orig_video)