Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max width to zoomed pictures. #1309

Closed
wants to merge 10 commits into from
Closed

Add max width to zoomed pictures. #1309

wants to merge 10 commits into from

Conversation

nymver
Copy link
Contributor

@nymver nymver commented Feb 7, 2024

Solves issue #1300

Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@nymver
Copy link
Contributor Author

nymver commented Feb 7, 2024

Again, my friend @Goosegit11 tested it on Firefox and I tested it on Chromium. Everything works.

@extesy
Copy link
Owner

extesy commented Feb 9, 2024

@nymver Thank you for the pull request and for testing it! The original request is asking for the maximum size, not just the width. There could be portrait-mode images what your PR will not limit. To completely address #1300 you would need to 1) rename maxWidth to maxSize, 2) limit both width and height of the image.

@extesy
Copy link
Owner

extesy commented Nov 8, 2024

Closing this PR as abandoned.

@extesy extesy closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants