Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CurrencyController has no method editAction as configured in ext_localconf.php #434

Open
rintisch opened this issue Dec 16, 2023 · 1 comment
Labels
9.x related to TYPO3 v12 bug needs feedback The author of the issue needs to add more information

Comments

@rintisch
Copy link
Collaborator

Bug Report

Current Behavior
Using the plugin "Cart: Currency Selector" throws the error TYPO3\CMS\Extbase\Mvc\Exception\NoSuchActionException
with the detailed information

"An action "editAction" does not exist in controller "Extcode\Cart\Controller\Cart\CurrencyController"."

Expected behavior/output
No error shall occur

Environment

  • TYPO3 version(s): 12.4
  • cart version: 9.x-dev
  • Is your TYPO3 installation set up with Composer (Composer Mode): yes
  • OS: running in ddev

Possible Solution
Implement the method editAction in the CurrencyController.

public function editAction(): ResponseInterface
    {
        $this->restoreSession();
        $this->view->assign('cart', $this->cart);
        return $this->htmlResponse();
    }

It will still not work because

  • the form works at the moment with AJAX
  • so the result will not be displayed because the form calls updateAction
  • so the AJAX response returns with field which do not exist at the moment in the template.
  • The JS tries to replace existing element with the updated elements but that does not work here because there are no original elements which could be replaced.

What was the idea? How is it intended to work?

@rintisch rintisch added 9.x related to TYPO3 v12 bug labels Mar 22, 2024
@rintisch
Copy link
Collaborator Author

@extcode Nobody seems to demand that feature, at least nobody seemed to miss it and I just found it by playing around. Do you want to solve the issue or can we remove the whole plugin?

In my experience this is in general not so useful because if I want to sells products in another currency that is in general another country so I would make a localized record with a real fitting price. I would remove it but that's of course breaking.

@rintisch rintisch added the needs feedback The author of the issue needs to add more information label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.x related to TYPO3 v12 bug needs feedback The author of the issue needs to add more information
Projects
None yet
Development

No branches or pull requests

1 participant