-
-
Notifications
You must be signed in to change notification settings - Fork 16k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies (5.0) #4282
Comments
Good conversation to have! Please don't take this response as a rebuttal, but as the start of a conversation and me thinking out loud. The It exists so that anyone in the ecosystem can use that same standard helper without having to keep that utility code in their own codebase. Having it as a package is essentially the same as if we had that same snippet of code in a utils folder, guarantees that any changes that ever need to happen to it will be synced across every package that uses it. Express maintains that package, as the I can't find where
The spread |
See #2755 (comment) for the 5.0 version support: |
I'm not sure if my comment is being misread here, but it is that we will support down to the LTS at the time, not that we won't support more than that. There has been further discussion since that thread, including in TC meetings, which is what @jonchurch is trying to represent. The version of support we are always aim for is as wide as possible, but there is a balance. Dropping versions for us is more about what we get for it, unrelated to what is supported by the Node.js project. But we will always support at least down to the current LTS version, no exceptions. |
Got it, I misunderstood it before, I thought we just need to support LTS at that time. |
No problem. Also (sorry!) to clarify: it doesn't mean this discussion is over at all; just it will help us to have discussions like this where we specify what the change in Node.js requirement will be for each one (like @jonchurch listed) so we can make decisions on what to do, etc. |
This comment has been minimized.
This comment has been minimized.
@dougwilson Thanks for the clarification. Just noticed it was here #4171 🙂 |
This comment has been minimized.
This comment has been minimized.
|
It seems that we can remove a few dependencies before the
5.0
release:methods
- We can use the built-inhttp
module:path-is-absolute
- We can use the built-inpath
module:safe-buffer
- We can use the built-inBuffer
:setprototypeof
- We can use theObject.setPrototypeOf()
utils-merge
- We can use the spread operator:The text was updated successfully, but these errors were encountered: