Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefer deflate only as last resort #26

Closed
dougwilson opened this issue Jan 1, 2015 · 4 comments
Closed

prefer deflate only as last resort #26

dougwilson opened this issue Jan 1, 2015 · 4 comments
Assignees

Comments

@dougwilson
Copy link
Contributor

Sending conforming DEFLATE responses are not accepted by any version of IE (IE 11 is current as of this writing); see some convo in #25. DEFLATE is still useful for clients that only support it and there's no real reason not to support it, but may as well send gzip even if the client says it prefers deflate more, as long as the client lists that it can accept gzip.

@dougwilson dougwilson self-assigned this Jan 1, 2015
@jonathanong
Copy link
Member

why not just not support it and not encode it? i'd prefer that vs. lying. in other words, only check gzip.

@dougwilson
Copy link
Contributor Author

vs. lying

How would this be lying? The server is allowed to negotiate just like the client.

why not just not support it and not encode it?

I looked at requests to our APIs and there are some Java and other non-browser clients that are only accepting deflate.

@jonathanong
Copy link
Member

oh sorry read it wrong. thought the clients were only sending DEFLATE. SGTM :D

@dougwilson
Copy link
Contributor Author

But yea, I think this is the best solution for the long term support :) I'm really surprised that IE 11 still doesn't work right w.r.t deflate, but LOL. I certainly don't really want to add UA sniffing in here though :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants