Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permissions should be False by default #677

Open
WillNilges opened this issue Sep 20, 2024 · 2 comments
Open

Permissions should be False by default #677

WillNilges opened this issue Sep 20, 2024 · 2 comments

Comments

@WillNilges
Copy link

Just had a bit of a scare. I did not set EXPLORER_PERMISSION_CHANGE in my settings.py, only EXPLORER_PERMISSION_VIEW. Because of this, /explorer/play and explorer/new were accessible by any user. I think it would be better if these defaulted to False to prevent access problems.
@WillNilges WillNilges changed the title Permissions should be False by default. Permissions should be False by default Sep 20, 2024
@chrisclark
Copy link
Collaborator

The default value is user.is_staff -- so unless that was overridden, it should not be the case that any user would have access. Can you expand a bit more?

@chrisclark
Copy link
Collaborator

@WillNilges would love to hear more about this. Please LMK. Otherwise I'll close the issue in a few days. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisclark @WillNilges