-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When should version 11 be released? #83
Comments
@expln : My inner 5-year-old wants everything in the current v11 list and more, and wants it right now :-). That said, I'm a believer in "release early, release often". The sooner you release, the sooner you get feedback on what's important (and what isn't). There's already more than enough functionality to justify a release, really. I have one request before v11 is released, if I may request it and it doesn't take too long:
That's weirdly specific, I know. The primary reason is that I want "enough UI stability" before I create a video, so that the video won't look too wrong when the next few tool releases come out. Issue #56 will involve a nontrivial UI change, so I'd rather have that in before making a video. I intend to focus on the 2+2=4 video, and visualization is definitely something I intend to emphasize. So I'd prefer it if its enabling/disability functionality per step was already implemented. Also, this ability will make it easier for users to explore the justifications, even on smaller screens. That way they can enable displaying just justifications in some places, and full visualizations in others. Given that, here at the headline items that I see:
Oh, this hints at a nomenclature change I'm thinking of doing in the guide. I now think I should say that a "proof consists of many steps", and each step includes an id, step type (H/P/G), justification (hyp and ref), and statement. If you have thoughts about that nomenclature change in the guide, please comment here: metamath/lamp-guide#62 |
So after you implement #56 and it's adequately reliable to your satisfaction, I recommend you ship it as version 11. Announce the results to the world, and move the other proposed items to version 12. Again, this is all up to you. But there's no reason to bottle up the goodness. There will always be something more you could add :-). |
Also, while there are many awesome proposals in the current v11 list, there are two larger capabilities, either of which might make sense for version 12:
Once you implement either one I think you should cut another release. Either one of those, by themselves, is helpful enough that users would immediately want it. |
You are right. I like this idea.
Sure, that should not take too long. I will include it into v11.
Almost everything you listed is ready. I agree with "release early, release often". So I will restructure my v11 list based on your response.
Yes, undo/redo should be implemented ASAP. As of "unify work variables more broadly", I also consider it as a an urgent change, but it may take some time because it may require to change some core functions. So you may see some other changes being implemented between "undo/redo" and "unify work variables more broadly". Thanks for your extensive feedback on the roadmap! Soon you may see I deploy new features to dev without detailed explanations in the corresponding issues - this is because I prefer to code in the beginning of the day and write comments in the evening. So, don't interpret this as I don't want to explain what I am doing, that's just my way of optimizing work :) |
That makes sense, that's what I expect will happen.
Sure! Thanks for this cool tool! I'm sure I'll have many more nits to report, but I wouldn't bother if it wasn't cool.
Sure! Thanks for letting me know. It clearly works for you :-). |
Wow! The latest improvements in the development version are stunning, especially on a smartphone. The new options (to make things fit on the screen better) make it much nicer on a smartphone, I even got to show the development version to a mathematician friend using my phone. I also like the ability to see the justification (ref and hyps) for each step; now it meets (and even exceeds) mmj2 in this area. I can't figure out how to get visualizations now from within the editor. I presume that's "work in progress". There are endless possible refinements, but that's the only blocker for me right now. I can't wait to see this wrapped up and released! |
I am glad you liked it!
mm-lamp is able to show visualizations only for steps marked with a green checkmark or with an orange I will explain this and all my other recent changes in more detail later today. |
On a smartphone I have justifications always displayed. When I touch the green checkmark, I usually see the compressed proof, but sometimes I see the visualization. It seems random which happens. |
The compressed proof is opened when you touch the green checkmark. The visualization is opened when you touch the label or the step type. The green checkmark and the label are located very close. I think you may be touching the green check mark unintentionally instead of the label. To open visualization, try to touch the label but more on the right side. Then you will be touching the label or the step type, but both of them will open the visualization. |
Ah! I was doing many experiments on my smartphone, where tooltips cannot be seen. Okay, here is what I think version 11 is doing (per comments above, tooltips, and experimentation):
The functionality is awesome, including controlling what's displayable. One problem I had in testing: When a justification is edited & then cancelled (or in other ways not edited), all checkmarks disappear & that disables visualizations. This led me to think that enabling visualizations was unreliable, because it's really easy to edit & cancel, thinking "nothing changed" but as a side-effect the visualizations got disabled. More generally, the mapping seems inconsistent. Editing is sometimes a long click and is sometimes a short click, depending on the field. I think that in an editor (at least) a "simple click" should always cause an edit if an edit makes sense, as that would be more consistent. The long-click would be used for some other behavior (like fragment selection). So I suggest this default mapping:
I also suggest that if "visualization toggle" tries to reveal a hidden visualization, automatically invoke unification if there isn't a green checkmark. After all, if the user requested it, the user presumably thinks it's possible & we should try to achieve it. Finally, as hinted above, it'd be better if editing the justification field, but not changing it, didn't remove green checkmarks. Noticing "nothing has changed", and doing nothing as a result, would eliminate a subtle UI trap. I note this now because I want to talk about the UI in my video, so if the default mappings are going to get changed I'd like that to happen sooner :-). In the longer term it'd be nice if touchscreens could see tooltips (e.g., show tooltips during a long-press, and if a user moves off the element it won't count as a long-press). Maybe tooltips coudl be revealed on "touch-down" and disappear on "touch-up"? In any case, supporting tooltips on touchscreens sounds like a "future version" capability sadly :-). |
Thank you!
I created a separate issue to discuss this - #97
Good idea, I created an issue for that #96
I saw you posted a comment #23 (comment) with some hint on how React allows to easily implement this. I will check it. Thanks!
I agree, this causes some inconvenience. This was the easiest way for me to ensure the UI doesn't show stale information. But for sure it can be and should be improved. I created a corresponding issue - #95 |
Continuing conversation from #107 (comment)
I found one bug. It happens when a statement may be proved by two different justifications. I will put undo/redo and full unification into the next version. Not necessarily v12, but I understand their importance, so I will work on them with the highest priority. I plan to release v11 by the end of this week. Usually I don't have enough time during working days, but I hope I will have enough time on the weekend.
That's nice! I am very glad that mm-lamp becomes useful :) |
The truly infinite thing in the universe is user feature requests, so I've created many :-). However, you've long since exceeded the bar of "is this version of the tool better than it was before". So I think whenever you decide to release it'll be great. The updated guide is generally ready; there are a few small things I intend to do this weekend as well, but don't wait for me! |
Thanks for your efforts to not leave me out of feature requests :) Yeah, I still plan to release it by the end of the week. There always will be some discrepancies between the app and the guide. But we will fix them and... make new ones :) |
I look forward to all the discrepancies you create because of new additions in the tool :-). |
You've obviously made the decision to release - thank you! I will close this comment, as it has been overcome by events. |
When should version 11 be released?
In the end, that decision is up to @expln . Here is expln's v11 milestone list
That said, it sounds like it'd be useful to have an organized place to discuss this, and I'd rather have an issue specifically focused on it.
As expln said in a comment in issue 16:
Since this is fundamentally about the tool, I've created an issue here in the tool issue tracker. A related issue is Create introduction videos with audio.
The text was updated successfully, but these errors were encountered: