Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do request() and exit() resolve with a value? #5

Open
foolip opened this issue Jan 18, 2024 · 1 comment
Open

Do request() and exit() resolve with a value? #5

foolip opened this issue Jan 18, 2024 · 1 comment

Comments

@foolip
Copy link

foolip commented Jan 18, 2024

From the API description and example, it's not clear if the intention is for nagivator.lockedMode.request() and nagivator.lockedMode.exit() to resolve with some value other than undefined. The example code saves enterResult and exitResult but I suspect there's no useful value to return.

@foolip
Copy link
Author

foolip commented Jan 18, 2024

There's another bit of the explainer that I think needs updating:

The user tries to convince the app that it is in Locked Mode when in fact it is not (e.g. by overwriting the navigator.lockedMode.request() method with their own that simply returns true at runtime).

I think this is supposed to say "that simply resolves without doing anything".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant