feat: ✨ improve message creation

expatfile · Apr 20, 2024 · b7dc0e0 · b7dc0e0
1 parent eddfa94
commit b7dc0e0
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 15 deletions.
diff --git a/protobuf-ts/src/client.ts b/protobuf-ts/src/client.ts
@@ -15,12 +15,12 @@ import {
 } from "./proto/test";
 
 export const readInputsCall = (client: TestServiceClient) => {
-  const request = TestServiceReadInputsRequest.create({
+  const request: TestServiceReadInputsRequest = {
     userId: faker.string.uuid(),
     taxYear: faker.number.int({ min: 2018, max: 2023 }).toString(),
     formName: faker.helpers.arrayElement(MOCK_FORM_NAMES),
     inputNames: MOCK_INPUT_NAMES,
-  });
+  };
 
   const metadata = new Metadata();
 
@@ -37,7 +37,7 @@ export const readInputsCall = (client: TestServiceClient) => {
 };
 
 export const updateInputsCall = (client: TestServiceClient) => {
-  const request = TestServiceUpdateInputsRequest.create({
+  const request: TestServiceUpdateInputsRequest = {
     userId: faker.string.uuid(),
     taxYear: faker.number.int({ min: 2018, max: 2023 }).toString(),
     formName: faker.helpers.arrayElement(MOCK_FORM_NAMES),
@@ -47,7 +47,7 @@ export const updateInputsCall = (client: TestServiceClient) => {
       type: faker.helpers.arrayElement(MOCK_INPUT_TYPES),
       source: faker.helpers.arrayElement(MOCK_INPUT_SOURCES),
     })),
-  });
+  };
 
   const metadata = new Metadata();
 

diff --git a/protobuf-ts/src/server.ts b/protobuf-ts/src/server.ts
@@ -33,9 +33,9 @@ const readInputs: handleUnaryCall<
     });
   });
 
-  const response = TestServiceReadInputsResponse.create({
+  const response: TestServiceReadInputsResponse = {
     inputs,
-  });
+  };
 
   callback(null, response);
 };
@@ -53,7 +53,7 @@ const updateInputs: handleUnaryCall<
 
   inputs.forEach(() => {});
 
-  const response = TestServiceUpdateInputsResponse.create();
+  const response: TestServiceUpdateInputsResponse = {};
 
   callback(null, response);
 };

diff --git a/ts-proto/gen_grpc.sh b/ts-proto/gen_grpc.sh
@@ -62,5 +62,5 @@ echo "\t└>  $SRC_DEST_DIR"
 $GRPC_TOOLS_NODE_PROTOC_PATH \
     --plugin=$PROTOC_GEN_TS_PROTO_PATH \
     --ts_proto_out=$SRC_DEST_DIR \
-    --ts_proto_opt=outputServices=grpc-js \
+    --ts_proto_opt=removeEnumPrefix=true,outputServices=grpc-js \
     -I $PROTO_DIR $PROTO_FILES
diff --git a/ts-proto/src/client.ts b/ts-proto/src/client.ts
@@ -14,12 +14,12 @@ import {
 } from "./proto/test";
 
 export const readInputsCall = (client: TestServiceClient) => {
-  const request = TestServiceReadInputsRequest.fromPartial({
+  const request: TestServiceReadInputsRequest = {
     userId: faker.string.uuid(),
     taxYear: faker.number.int({ min: 2018, max: 2023 }).toString(),
     formName: faker.helpers.arrayElement(MOCK_FORM_NAMES),
     inputNames: MOCK_INPUT_NAMES,
-  });
+  };
 
   const metadata = new Metadata();
 
@@ -36,7 +36,7 @@ export const readInputsCall = (client: TestServiceClient) => {
 };
 
 export const updateInputsCall = (client: TestServiceClient) => {
-  const request = TestServiceUpdateInputsRequest.fromPartial({
+  const request: TestServiceUpdateInputsRequest = {
     userId: faker.string.uuid(),
     taxYear: faker.number.int({ min: 2018, max: 2023 }).toString(),
     formName: faker.helpers.arrayElement(MOCK_FORM_NAMES),
@@ -46,7 +46,7 @@ export const updateInputsCall = (client: TestServiceClient) => {
       type: faker.helpers.arrayElement(MOCK_INPUT_TYPES),
       source: faker.helpers.arrayElement(MOCK_INPUT_SOURCES),
     })),
-  });
+  };
 
   const metadata = new Metadata();
 

diff --git a/ts-proto/src/server.ts b/ts-proto/src/server.ts
@@ -32,9 +32,9 @@ const readInputs: handleUnaryCall<
     });
   });
 
-  const response = TestServiceReadInputsResponse.fromPartial({
+  const response: TestServiceReadInputsResponse = {
     inputs,
-  });
+  };
 
   callback(null, response);
 };
@@ -52,7 +52,7 @@ const updateInputs: handleUnaryCall<
 
   inputs.forEach(() => {});
 
-  const response = TestServiceUpdateInputsResponse.fromPartial({});
+  const response: TestServiceUpdateInputsResponse = {};
 
   callback(null, response);
 };