Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete --detailext, --detailcia, --saveext arguments #6

Open
pcubillos opened this issue Feb 26, 2015 · 2 comments
Open

Delete --detailext, --detailcia, --saveext arguments #6

pcubillos opened this issue Feb 26, 2015 · 2 comments

Comments

@pcubillos
Copy link
Member

Should we remove these arguments? The way they are implemented is pretty much useless:

--detailext=filename:wn1,wn2,...
Save extinction at specified wavenumbers in filename.
--detailcia=filename:wn1,wn2,...
Save CIA extinction at specified wavenumbers in filename.
--saveext=
Save extinction array in this file which won’t need to be recomputed if only the radius scale (scale height) changes.

We should either remove them, or re-implement them into a useful tool, maybe save the whole arrays, rather than just at a few wns.

Saving the opacity for the atmospheric model would be actually useful (for the contribution plots).

aj-foster added a commit that referenced this issue Jul 6, 2015
This Makefile naively forwards the "make" commands to the various modules.
Resolves #6.
@aj-foster
Copy link
Contributor

Have you made a decision on which way to go?

@pcubillos
Copy link
Member Author

Not yet, I think jasmina re-purposed these (or some of these) variables already. I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants