Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNV parse issue #52

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

MNV parse issue #52

wants to merge 1 commit into from

Conversation

ielis
Copy link
Collaborator

@ielis ielis commented Jun 17, 2021

Hi @julesjacobsen

this is the issue I mentioned with MNVs. MNVs having alleles of different length are not recognized as MNV, but as INS or DEL. This makes the test cases 3 and 4 in the snippet below (excerpt from VariantTypeTest) to fail. Also, I think the test cases 5, 6 are incorrect, as these are in fact MNVs and not DEL/INS.

@ParameterizedTest
    @CsvSource({
            "A, T,    SNV",
            "ATG, TCA,    MNV",
            "ATG, TC,    MNV",
            "AT, TCA,    MNV",
            "TC, A,    DEL",
            "A, TC,    INS",
            "N, <DEL>,    DEL",
            "N, <INS>,    INS",
            "N, <INS:ME>,    INS_ME",
            "'', <INS:ME>,    INS_ME",
            "N, <INS:ME:ALU>,    INS_ME_ALU",
            "N, <CNV:GAIN>,    CNV_GAIN",
            "N, C[2:12345[,    BND",
    })
    public void parseTypeRefAlt(String ref, String alt, VariantType baseType) {
        assertThat(VariantType.parseType(ref, alt), equalTo(baseType));
    }

I'll be working on a fix and I'll add the code here.

@ielis ielis requested a review from julesjacobsen June 17, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant