Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add concept exercise for headers #741

Merged
merged 3 commits into from
Nov 8, 2023
Merged

feat: add concept exercise for headers #741

merged 3 commits into from
Nov 8, 2023

Conversation

vaeng
Copy link
Contributor

@vaeng vaeng commented Nov 5, 2023

No description provided.

@vaeng vaeng force-pushed the feat--add-header-testing-concept branch from 2ec466b to fb51006 Compare November 7, 2023 20:57
@vaeng vaeng changed the title tmp: playground to test exercise feat: add concept exercise for headers Nov 7, 2023
@vaeng vaeng marked this pull request as ready for review November 7, 2023 20:58
@vaeng
Copy link
Contributor Author

vaeng commented Nov 7, 2023

So this is iteration number three to get a good introduction to header files.
I combined it with a general tutorial for the practice exercise.
All thoughts welcome :)

BethanyG
BethanyG reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@BethanyG BethanyG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I left quite a few nits, most of which are optional. I left the nitty-gritty code review to those much better versed in C++ than I. 😅

exercises/concept/doctor-data/.docs/hints.md Outdated Show resolved Hide resolved
exercises/concept/doctor-data/.docs/hints.md Outdated Show resolved Hide resolved
exercises/concept/doctor-data/.docs/hints.md Outdated Show resolved Hide resolved
exercises/concept/doctor-data/.docs/hints.md Outdated Show resolved Hide resolved
exercises/concept/doctor-data/.docs/instructions.md Outdated Show resolved Hide resolved
exercises/concept/doctor-data/.docs/introduction.md Outdated Show resolved Hide resolved
exercises/concept/doctor-data/.docs/introduction.md Outdated Show resolved Hide resolved
exercises/concept/doctor-data/.docs/introduction.md Outdated Show resolved Hide resolved
exercises/concept/doctor-data/.docs/introduction.md Outdated Show resolved Hide resolved
exercises/concept/doctor-data/.docs/introduction.md Outdated Show resolved Hide resolved
ErikSchierboom
ErikSchierboom approved these changes Nov 8, 2023
View reviewed changes
exercises/concept/doctor-data/.docs/hints.md Outdated Show resolved Hide resolved
exercises/concept/doctor-data/.docs/hints.md Outdated Show resolved Hide resolved
exercises/concept/doctor-data/.docs/instructions.md Show resolved Hide resolved
@vaeng vaeng self-assigned this Nov 8, 2023
@vaeng vaeng added x:module/concept-exercise Work on Concept Exercises x:type/content Work on content (e.g. exercises, concepts) x:rep/large Large amount of reputation labels Nov 8, 2023
@vaeng vaeng merged commit 296f409 into main Nov 8, 2023
8 checks passed
@vaeng vaeng deleted the feat--add-header-testing-concept branch November 8, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethanyG BethanyG BethanyG left review comments

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

@siebenschlaefer siebenschlaefer Awaiting requested review from siebenschlaefer

Assignees

@vaeng vaeng

Labels
x:module/concept-exercise Work on Concept Exercises x:rep/large Large amount of reputation x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaeng @ErikSchierboom @BethanyG