Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /WX (warnings as errors) compile flag when compiling with MSVC. #923

Merged
merged 5 commits into from
Nov 3, 2024

Conversation

heijp06
Copy link
Contributor

@heijp06 heijp06 commented Nov 2, 2024

This PR fixes #922. When compiling with MSVC (Microsoft Visual C++) warnings are now treated as errors for all exercises.

Copy link
Contributor

github-actions bot commented Nov 2, 2024

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Nov 2, 2024
@heijp06
Copy link
Contributor Author

heijp06 commented Nov 2, 2024

@vaeng, I created this PR for #922.

@vaeng vaeng reopened this Nov 3, 2024
@vaeng
Copy link
Contributor

vaeng commented Nov 3, 2024

I assume you replaced the lines for all exercises and did not add anything else? I scrolled through the changes and read your explanation in the issue. Thanks for the write-up that helps a lot to speed things up.

I would love to have a single space for those files and have each exercise pull from that folder, but currently, we have to change it everywhere.

It is a good change, if all tests pass, we should merge this.

@vaeng vaeng added x:module/practice-exercise Work on Practice Exercises x:action/improve Improve existing functionality/content x:module/concept Work on Concepts x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows) labels Nov 3, 2024
@vaeng
Copy link
Contributor

vaeng commented Nov 3, 2024

I see you did some other corrections. It's good that you kept those in different commits, so I can judge them faster.

@vaeng vaeng merged commit 19bef29 into exercism:main Nov 3, 2024
16 checks passed
@heijp06 heijp06 deleted the msvc_warnings_as_errors branch November 5, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/improve Improve existing functionality/content x:module/concept Work on Concepts x:module/practice-exercise Work on Practice Exercises x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exercises are not compiled with "warnings as errors" with MSVC (Microsoft Visual C++).
2 participants