-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add /WX (warnings as errors) compile flag when compiling with MSVC. #923
Conversation
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
…nd CLang are fine with those conversions.
I assume you replaced the lines for all exercises and did not add anything else? I scrolled through the changes and read your explanation in the issue. Thanks for the write-up that helps a lot to speed things up. I would love to have a single space for those files and have each exercise pull from that folder, but currently, we have to change it everywhere. It is a good change, if all tests pass, we should merge this. |
I see you did some other corrections. It's good that you kept those in different commits, so I can judge them faster. |
This PR fixes #922. When compiling with MSVC (Microsoft Visual C++) warnings are now treated as errors for all exercises.