Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: please provide support for sphinx 5.x and pydata-sphinx-theme 0.9.0 #571

Closed
kloczek opened this issue Jun 13, 2022 · 6 comments
Closed

Comments

@kloczek
Copy link
Contributor

kloczek commented Jun 13, 2022

dependencies = [
"sphinx>=3,<5",
"pydata-sphinx-theme~=0.8.0",

@welcome
Copy link

welcome bot commented Jun 13, 2022

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@kloczek kloczek changed the title RFE: pleas eproviide support for sphinx 5.x and pydata-sphinx-theme 0.9.0 RFE: please provide support for sphinx 5.x and pydata-sphinx-theme 0.9.0 Jun 13, 2022
@SilverRainZ
Copy link

On Arch Linux, I use Sphinx 5.x from the system path, and sphinx-book-theme from user path works fine with it, so I think we can just relax this constraint?

@kloczek
Copy link
Contributor Author

kloczek commented Jun 18, 2022

Without patching that fragment you cannot pass typical pep517 build based process.
I've trimmed that line in my spec file and I don't see so far any negative symptoms using such product however I've been using produced package only to build another three other packages

[tkloczko@devel-g2v SPECS]$ grep sphinx-book-theme * -l
python-dask-sphinx-theme.spec
python-myst-nb.spec
python-pooch.spec
python-sphinx-book-theme.spec

@pradyunsg
Copy link
Member

x-ref executablebooks/meta#750

There's a checklist on that issue. Contributions are welcome. :)

@pradyunsg pradyunsg changed the title RFE: please provide support for sphinx 5.x and pydata-sphinx-theme 0.9.0 Sphinx 5 support Jun 18, 2022
@pradyunsg pradyunsg changed the title Sphinx 5 support RFE: please provide support for sphinx 5.x and pydata-sphinx-theme 0.9.0 Jun 18, 2022
@pradyunsg
Copy link
Member

I've filed #575 for tracking the pydata upgrade (there's an open PR for it, and this issue is broader than that) and the meta issue is already tracking Sphinx 5 support across the executablebooks org, so I'm gonna go ahead and close this.

Thanks for chiming in with context on how Sphinx 5 + sphinx book theme is working for you @SilverRainZ! ^>^

@kloczek
Copy link
Contributor Author

kloczek commented Jul 17, 2022

Issue still is not resolved

"sphinx>=3,<5",

"sphinx~=4.0", # Force Sphinx to be the latest version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants