From d865e48f6b35b6cca65afaef59b1c4c603614ba7 Mon Sep 17 00:00:00 2001 From: Chris Oliver Date: Fri, 6 Sep 2024 09:19:59 -0500 Subject: [PATCH] Add missing assertions to tests --- test/bulk_delivery_methods/webhook_test.rb | 17 +++++++++++++---- test/delivery_methods/fcm_test.rb | 4 +++- test/delivery_methods/microsoft_teams_test.rb | 4 +++- test/delivery_methods/slack_test.rb | 4 +++- .../delivery_methods/twilio_messaging_test.rb | 5 ++++- test/delivery_methods/vonage_sms_test.rb | 4 +++- test/delivery_methods/webhook_test.rb | 19 +++++++++++++++---- test/notifier_test.rb | 4 +++- 8 files changed, 47 insertions(+), 14 deletions(-) diff --git a/test/bulk_delivery_methods/webhook_test.rb b/test/bulk_delivery_methods/webhook_test.rb index 33a2d24c..0a1196da 100644 --- a/test/bulk_delivery_methods/webhook_test.rb +++ b/test/bulk_delivery_methods/webhook_test.rb @@ -12,7 +12,9 @@ class WebhookBulkDeliveryMethodTest < ActiveSupport::TestCase ) stub_request(:post, "https://example.org/webhook").with(body: "{\"foo\":\"bar\"}") - @delivery_method.deliver + assert_nothing_raised do + @delivery_method.deliver + end end test "webhook with form payload" do @@ -21,7 +23,9 @@ class WebhookBulkDeliveryMethodTest < ActiveSupport::TestCase form: {foo: :bar} ) stub_request(:post, "https://example.org/webhook").with(headers: {"Content-Type" => /application\/x-www-form-urlencoded/}) - @delivery_method.deliver + assert_nothing_raised do + @delivery_method.deliver + end end test "webhook with basic auth" do @@ -30,7 +34,9 @@ class WebhookBulkDeliveryMethodTest < ActiveSupport::TestCase basic_auth: {user: "username", pass: "password"} ) stub_request(:post, "https://example.org/webhook").with(headers: {"Authorization" => "Basic dXNlcm5hbWU6cGFzc3dvcmQ="}) - @delivery_method.deliver + assert_nothing_raised do + @delivery_method.deliver + end end test "webhook with headers" do @@ -39,7 +45,10 @@ class WebhookBulkDeliveryMethodTest < ActiveSupport::TestCase headers: {"Content-Type" => "application/json"} ) stub_request(:post, "https://example.org/webhook").with(headers: {"Content-Type" => "application/json"}) - @delivery_method.deliver + + assert_nothing_raised do + @delivery_method.deliver + end end test "webhook raises error with unsuccessful status codes" do diff --git a/test/delivery_methods/fcm_test.rb b/test/delivery_methods/fcm_test.rb index 3eb58275..fd3f33d9 100644 --- a/test/delivery_methods/fcm_test.rb +++ b/test/delivery_methods/fcm_test.rb @@ -37,7 +37,9 @@ def fetch_access_token! stub_request(:post, "https://fcm.googleapis.com/v1/projects/p_1234/messages:send").with(body: "{\"message\":{\"token\":\"a\",\"notification\":{\"title\":\"Title\",\"body\":\"Body\"}}}") stub_request(:post, "https://fcm.googleapis.com/v1/projects/p_1234/messages:send").with(body: "{\"message\":{\"token\":\"b\",\"notification\":{\"title\":\"Title\",\"body\":\"Body\"}}}") - @delivery_method.deliver + assert_nothing_raised do + @delivery_method.deliver + end end test "notifies of invalid tokens for clean up" do diff --git a/test/delivery_methods/microsoft_teams_test.rb b/test/delivery_methods/microsoft_teams_test.rb index e8eed267..04cfd5c1 100644 --- a/test/delivery_methods/microsoft_teams_test.rb +++ b/test/delivery_methods/microsoft_teams_test.rb @@ -11,7 +11,9 @@ class MicrosoftTeamsTest < ActiveSupport::TestCase test "sends a message" do stub_request(:post, "https://teams.microsoft.com").with(body: "{\"foo\":\"bar\"}") - @delivery_method.deliver + assert_nothing_raised do + @delivery_method.deliver + end end test "raises error on failure" do diff --git a/test/delivery_methods/slack_test.rb b/test/delivery_methods/slack_test.rb index fdd671e2..c1b4fb91 100644 --- a/test/delivery_methods/slack_test.rb +++ b/test/delivery_methods/slack_test.rb @@ -8,7 +8,9 @@ class SlackTest < ActiveSupport::TestCase test "sends a slack message" do stub_request(:post, Noticed::DeliveryMethods::Slack::DEFAULT_URL).with(body: "{\"foo\":\"bar\"}") - @delivery_method.deliver + assert_nothing_raised do + @delivery_method.deliver + end end test "raises error on failure" do diff --git a/test/delivery_methods/twilio_messaging_test.rb b/test/delivery_methods/twilio_messaging_test.rb index df6a7de3..f9dca025 100644 --- a/test/delivery_methods/twilio_messaging_test.rb +++ b/test/delivery_methods/twilio_messaging_test.rb @@ -29,7 +29,10 @@ class TwilioMessagingTest < ActiveSupport::TestCase Body: "Hello world" } ).to_return(status: 200) - @delivery_method.deliver + + assert_nothing_raised do + @delivery_method.deliver + end end test "raises error on failure" do diff --git a/test/delivery_methods/vonage_sms_test.rb b/test/delivery_methods/vonage_sms_test.rb index dd49c48e..22ee8232 100644 --- a/test/delivery_methods/vonage_sms_test.rb +++ b/test/delivery_methods/vonage_sms_test.rb @@ -8,7 +8,9 @@ class VonageSmsTest < ActiveSupport::TestCase test "sends sms" do set_config(json: {foo: :bar}) stub_request(:post, Noticed::DeliveryMethods::VonageSms::DEFAULT_URL).with(body: "{\"foo\":\"bar\"}").to_return(status: 200, body: "{\"messages\":[{\"status\":\"0\"}]}") - @delivery_method.deliver + assert_nothing_raised do + @delivery_method.deliver + end end test "raises error on failure" do diff --git a/test/delivery_methods/webhook_test.rb b/test/delivery_methods/webhook_test.rb index ee9f52d3..4a31b423 100644 --- a/test/delivery_methods/webhook_test.rb +++ b/test/delivery_methods/webhook_test.rb @@ -12,7 +12,9 @@ class WebhookDeliveryMethodTest < ActiveSupport::TestCase ) stub_request(:post, "https://example.org/webhook").with(body: "{\"foo\":\"bar\"}") - @delivery_method.deliver + assert_nothing_raised do + @delivery_method.deliver + end end test "webhook with form payload" do @@ -21,7 +23,10 @@ class WebhookDeliveryMethodTest < ActiveSupport::TestCase form: {foo: :bar} ) stub_request(:post, "https://example.org/webhook").with(headers: {"Content-Type" => /application\/x-www-form-urlencoded/}) - @delivery_method.deliver + + assert_nothing_raised do + @delivery_method.deliver + end end test "webhook with basic auth" do @@ -30,7 +35,10 @@ class WebhookDeliveryMethodTest < ActiveSupport::TestCase basic_auth: {user: "username", pass: "password"} ) stub_request(:post, "https://example.org/webhook").with(headers: {"Authorization" => "Basic dXNlcm5hbWU6cGFzc3dvcmQ="}) - @delivery_method.deliver + + assert_nothing_raised do + @delivery_method.deliver + end end test "webhook with headers" do @@ -39,7 +47,10 @@ class WebhookDeliveryMethodTest < ActiveSupport::TestCase headers: {"Content-Type" => "application/json"} ) stub_request(:post, "https://example.org/webhook").with(headers: {"Content-Type" => "application/json"}) - @delivery_method.deliver + + assert_nothing_raised do + @delivery_method.deliver + end end test "webhook raises error with unsuccessful status codes" do diff --git a/test/notifier_test.rb b/test/notifier_test.rb index 99ac26ba..a6678d9e 100644 --- a/test/notifier_test.rb +++ b/test/notifier_test.rb @@ -71,7 +71,9 @@ def recipients end test "deliver without recipients" do - ReceiptNotifier.deliver + assert_nothing_raised do + ReceiptNotifier.deliver + end end test "deliver creates an event" do