Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistency between exercises 1 and 6 #25

Open
marcinwasilewski opened this issue May 6, 2017 · 1 comment
Open

inconsistency between exercises 1 and 6 #25

marcinwasilewski opened this issue May 6, 2017 · 1 comment

Comments

@marcinwasilewski
Copy link

The 1st exercise - separation of concerns - calls for moving 4 methods from vendingMachine.js to balanceManager.js. The official solution includes increaseBalance, decreaseBalance, getBalance and canAfford. However, in the exercise "Fix your teammate's mistakes", the test calls for function isValidAmount from the module balanceManager.js, which at the time would have not been separated from vendingMachine.js.

The solution for this issue would involve adding isValidAmount as a fifth method to the test cases of the SoC exercise as well as some amendments to that exercise description.

doug2k1 pushed a commit to doug2k1/js-best-practices-workshopper that referenced this issue Oct 2, 2017
doug2k1 added a commit to doug2k1/js-best-practices-workshopper that referenced this issue Oct 2, 2017
doug2k1 added a commit to doug2k1/js-best-practices-workshopper that referenced this issue Oct 2, 2017
@idosius
Copy link

idosius commented Jul 15, 2020

Also, the code presented in the solution is different than the code available, so the solution should be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants