Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IDs rather than names everywhere programmatic identifiers are needed #31

Open
2 tasks
SeanKilleen opened this issue Jun 29, 2022 · 0 comments
Open
2 tasks

Use IDs rather than names everywhere programmatic identifiers are needed #31

SeanKilleen opened this issue Jun 29, 2022 · 0 comments

Comments

@SeanKilleen
Copy link
Contributor

SeanKilleen commented Jun 29, 2022 •
edited
Loading

Names and orgs can change on GitHub. Need to be conscious of using IDs where we can.

  • PersistentRepoActor uses the name in the Persistence ID
  • PersistenUserActor uses the org name in the AddOrgForUserCommand, but would need to discover the org ID before processing the command in that case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SeanKilleen