-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make this a built-in transformer? #2
Comments
I'd be happy to do this, but I just wanted you to be aware that this transformer includes |
@trevorblades Hmmm that would be a bummer, since that's a large one... Although we could add this to the README that Would be better if @excalidraw was providing an |
It is a large one, but on the other hand, it won't have an impact on the bundle size of the built Gatsby website, since Here's a PR for this change: MichaelDeBoey/gatsby-remark-embedder#122 🎉 |
As I expressed in MichaelDeBoey/gatsby-remark-embedder#122 (comment), I think it makes the most sense to keep this as a separate library for now. If a dependency-free solution (ie. an API endpoint or oEmbed) appears in the future, we can revisit this. For now, it sounds like this would not be possible due to the nature of Excalidraw's encryption model: MichaelDeBoey/gatsby-remark-embedder#122 (comment) |
I'd love to have this one by default in the plugin. 👊
@trevorblades @j-f1 @lipis Would you mind creating a PR for this please? 🤔
The text was updated successfully, but these errors were encountered: