From 85e82f4e5b2be56a4d6be77bf39ee45397936298 Mon Sep 17 00:00:00 2001 From: danilo neves cruz Date: Wed, 3 Jul 2024 20:13:41 -0300 Subject: [PATCH] =?UTF-8?q?=F0=9F=93=9D=20plugin:=20document=20`onInstall`?= =?UTF-8?q?=20difference=20from=20`MultiOwnerPlugin`?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit addresses quantstamp EXA-S-6 --- .gas-snapshot | 4 ++-- src/WebauthnOwnerPlugin.sol | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.gas-snapshot b/.gas-snapshot index 20b0e8e..70b0c35 100644 --- a/.gas-snapshot +++ b/.gas-snapshot @@ -5,13 +5,13 @@ MultiOwnerPluginIntegration:test_userOpValidation_owner_standardExecute() (gas: MultiOwnerPluginTest:testFuzz_isValidSignature_ContractOwner(bytes32) (runs: 256, μ: 110067, ~: 110067) MultiOwnerPluginTest:testFuzz_isValidSignature_ContractOwnerWithEOAOwner(bytes32) (runs: 256, μ: 120381, ~: 120381) MultiOwnerPluginTest:testFuzz_isValidSignature_EOAOwner(string,bytes32) (runs: 256, μ: 130741, ~: 130734) -MultiOwnerPluginTest:testFuzz_isValidSignature_PasskeyOwner(bytes32) (runs: 256, μ: 365543, ~: 365705) +MultiOwnerPluginTest:testFuzz_isValidSignature_PasskeyOwner(bytes32) (runs: 256, μ: 365504, ~: 365652) MultiOwnerPluginTest:testFuzz_runtimeValidationFunction_BadFunctionId(uint8) (runs: 256, μ: 9747, ~: 9747) MultiOwnerPluginTest:testFuzz_userOpValidationFunction_BadFunctionId(uint8) (runs: 256, μ: 10744, ~: 10744) MultiOwnerPluginTest:testFuzz_userOpValidationFunction_ContractOwner((address,uint256,bytes,bytes,uint256,uint256,uint256,uint256,uint256,bytes,bytes)) (runs: 256, μ: 130908, ~: 130897) MultiOwnerPluginTest:testFuzz_userOpValidationFunction_ContractOwnerWithEOAOwner((address,uint256,bytes,bytes,uint256,uint256,uint256,uint256,uint256,bytes,bytes)) (runs: 256, μ: 144523, ~: 144512) MultiOwnerPluginTest:testFuzz_userOpValidationFunction_EOAOwner(string,(address,uint256,bytes,bytes,uint256,uint256,uint256,uint256,uint256,bytes,bytes)) (runs: 256, μ: 138777, ~: 138780) -MultiOwnerPluginTest:testFuzz_userOpValidationFunction_PasskeyOwner((address,uint256,bytes,bytes,uint256,uint256,uint256,uint256,uint256,bytes,bytes)) (runs: 256, μ: 373615, ~: 373631) +MultiOwnerPluginTest:testFuzz_userOpValidationFunction_PasskeyOwner((address,uint256,bytes,bytes,uint256,uint256,uint256,uint256,uint256,bytes,bytes)) (runs: 256, μ: 373691, ~: 373630) MultiOwnerPluginTest:test_eip712Domain() (gas: 35438) MultiOwnerPluginTest:test_isValidSignature_failMalformedAddress() (gas: 15544) MultiOwnerPluginTest:test_isValidSignature_failWithOutOfBounds() (gas: 12319) diff --git a/src/WebauthnOwnerPlugin.sol b/src/WebauthnOwnerPlugin.sol index b09fd0f..2606aaf 100644 --- a/src/WebauthnOwnerPlugin.sol +++ b/src/WebauthnOwnerPlugin.sol @@ -125,6 +125,7 @@ contract WebauthnOwnerPlugin is BasePlugin, IWebauthnOwnerPlugin, IERC1271 { } /// @inheritdoc BasePlugin + /// @param data ABI-encoded array of `PublicKey` elements. It differs from `MultiOwnerPlugin`'s array of `address`. function _onInstall(bytes calldata data) internal override isNotInitialized(msg.sender) { (PublicKey[] memory initialOwners) = abi.decode(data, (PublicKey[])); if (initialOwners.length == 0) revert EmptyOwnersNotAllowed();