From 21fc6a22d3441e849b6b568cd830b73153be1d20 Mon Sep 17 00:00:00 2001 From: danilo neves cruz Date: Wed, 3 Jul 2024 19:02:58 -0300 Subject: [PATCH] =?UTF-8?q?=F0=9F=93=9D=20plugin:=20document=20no=20signat?= =?UTF-8?q?ure=20expiry?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .gas-snapshot | 2 +- src/WebauthnOwnerPlugin.sol | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.gas-snapshot b/.gas-snapshot index 4446394..20b0e8e 100644 --- a/.gas-snapshot +++ b/.gas-snapshot @@ -11,7 +11,7 @@ MultiOwnerPluginTest:testFuzz_userOpValidationFunction_BadFunctionId(uint8) (run MultiOwnerPluginTest:testFuzz_userOpValidationFunction_ContractOwner((address,uint256,bytes,bytes,uint256,uint256,uint256,uint256,uint256,bytes,bytes)) (runs: 256, μ: 130908, ~: 130897) MultiOwnerPluginTest:testFuzz_userOpValidationFunction_ContractOwnerWithEOAOwner((address,uint256,bytes,bytes,uint256,uint256,uint256,uint256,uint256,bytes,bytes)) (runs: 256, μ: 144523, ~: 144512) MultiOwnerPluginTest:testFuzz_userOpValidationFunction_EOAOwner(string,(address,uint256,bytes,bytes,uint256,uint256,uint256,uint256,uint256,bytes,bytes)) (runs: 256, μ: 138777, ~: 138780) -MultiOwnerPluginTest:testFuzz_userOpValidationFunction_PasskeyOwner((address,uint256,bytes,bytes,uint256,uint256,uint256,uint256,uint256,bytes,bytes)) (runs: 256, μ: 373606, ~: 373621) +MultiOwnerPluginTest:testFuzz_userOpValidationFunction_PasskeyOwner((address,uint256,bytes,bytes,uint256,uint256,uint256,uint256,uint256,bytes,bytes)) (runs: 256, μ: 373615, ~: 373631) MultiOwnerPluginTest:test_eip712Domain() (gas: 35438) MultiOwnerPluginTest:test_isValidSignature_failMalformedAddress() (gas: 15544) MultiOwnerPluginTest:test_isValidSignature_failWithOutOfBounds() (gas: 12319) diff --git a/src/WebauthnOwnerPlugin.sol b/src/WebauthnOwnerPlugin.sol index ffe8c9f..b09fd0f 100644 --- a/src/WebauthnOwnerPlugin.sol +++ b/src/WebauthnOwnerPlugin.sol @@ -333,6 +333,7 @@ contract WebauthnOwnerPlugin is BasePlugin, IWebauthnOwnerPlugin, IERC1271 { return keccak256(abi.encode(_TYPE_HASH, _NAME_HASH, _VERSION_HASH, block.chainid, account, _SALT)); } + /// @notice Signatures are valid indefinitely. /// @dev Webauthn public keys with `y` as 0 are not supported, as they will be treated as Ethereum addresses. function _validateSignature(address account, bytes32 message, bytes calldata signature) internal view returns (bool) { PublicKey memory owner = _owners[account].get(uint8(signature[0]));