Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core getField method need refactor #228

Open
Pathologic opened this issue Jan 17, 2023 · 1 comment
Open

Core getField method need refactor #228

Pathologic opened this issue Jan 17, 2023 · 1 comment
Labels
refactor Something need changes

Comments

@Pathologic
Copy link
Contributor

Pathologic commented Jan 17, 2023 •
edited
Loading

Observed behavior

This method uses document object to get particular field. If this field is TV then getDocument method is called to get document again 😕 Then TV is processed by getTVDisplayFormat function - but is it needed? Maybe additional parameter should be added to getField.

Expected behavior

Document object is enough to get TV with getTVDisplayFormat or without.

Related issue(s)/PR(s)

#227

Environment

EvoCMS version: 3.x
@Pathologic Pathologic added bug Something isn't working refactor Something need changes and removed bug Something isn't working labels Jan 17, 2023
@Pathologic Pathologic changed the title [BUG] Core getField method needs refactor Core getField method needs refactor Jan 17, 2023
@Pathologic Pathologic changed the title Core getField method needs refactor Core getField method need refactor Jan 17, 2023
@Pathologic
Copy link
Contributor Author

There's another problem - getDocumentObject call can be finished with redirect, that's wrong behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Something need changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Pathologic