Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 10.2 warnings #16

Open
mannd opened this issue Mar 29, 2019 · 2 comments
Open

Xcode 10.2 warnings #16

mannd opened this issue Mar 29, 2019 · 2 comments

Comments

@mannd
Copy link

mannd commented Mar 29, 2019

Xcode 10.2 gives multiple warnings in multiple files:
'public' modifier is redundant for static method declared in a public extension, for example
in CentralMoment.swift line 36:

public static func centralMoment(_ values: [Double], order: Int) -> Double? {

It seems that the access level of the extension is the default access level of each method in the extension. To get rid of the warning, one must remove these public access modifiers, or change the default access level of each extension to something other than public.

This stack overflow post addresses the issue:

https://stackoverflow.com/questions/34470589/will-marking-swift-extension-public-change-the-property-in-the-extension-to-be-i

@evgenyneu
Copy link
Owner

Thanks for reporting the issues, @mannd. I've updated the code for Swift 5.0 and released it in version 9 to CocoaPods.

@mannd
Copy link
Author

mannd commented Apr 3, 2019

Great! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants