From ef9af32ba28cfca6388ee03ea0a569de05b625b7 Mon Sep 17 00:00:00 2001 From: Annie Black Date: Wed, 29 May 2024 11:43:35 -0400 Subject: [PATCH] DEVPROD-6656 unhide distro warnings field (#142) --- .../cypress/integration/distroSettings/general_section.ts | 7 +++---- .../pages/distroSettings/tabs/GeneralTab/getFormSchema.ts | 3 +-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/apps/spruce/cypress/integration/distroSettings/general_section.ts b/apps/spruce/cypress/integration/distroSettings/general_section.ts index 4d052daf1..9495d4e43 100644 --- a/apps/spruce/cypress/integration/distroSettings/general_section.ts +++ b/apps/spruce/cypress/integration/distroSettings/general_section.ts @@ -1,6 +1,5 @@ import { save } from "./utils"; -// TODO: https://jira.mongodb.org/browse/DEVPROD-6656 - Uncomment the Warnings assertions when the backend supports it describe("general section", () => { beforeEach(() => { cy.visit("/distro/localhost/settings/general"); @@ -17,7 +16,7 @@ describe("general section", () => { cy.contains("button", "Add alias").click(); cy.getInputByLabel("Alias").type("localhost-alias"); cy.getInputByLabel("Notes").type("this is a note"); - // cy.getInputByLabel("Warnings").type("this is a warning"); + cy.getInputByLabel("Warnings").type("this is a warning"); cy.getInputByLabel("Disable shallow clone for this distro").check({ force: true, }); @@ -29,7 +28,7 @@ describe("general section", () => { cy.reload(); cy.getInputByLabel("Alias").should("have.value", "localhost-alias"); cy.getInputByLabel("Notes").should("have.value", "this is a note"); - // cy.getInputByLabel("Warnings").should("have.value", "this is a warning"); + cy.getInputByLabel("Warnings").should("have.value", "this is a warning"); cy.getInputByLabel("Disable shallow clone for this distro").should( "be.checked", ); @@ -38,7 +37,7 @@ describe("general section", () => { // Undo changes. cy.dataCy("delete-item-button").click(); cy.getInputByLabel("Notes").clear(); - // cy.getInputByLabel("Warnings").clear(); + cy.getInputByLabel("Warnings").clear(); cy.getInputByLabel("Disable shallow clone for this distro").uncheck({ force: true, }); diff --git a/apps/spruce/src/pages/distroSettings/tabs/GeneralTab/getFormSchema.ts b/apps/spruce/src/pages/distroSettings/tabs/GeneralTab/getFormSchema.ts index 126fd1859..8323268b4 100644 --- a/apps/spruce/src/pages/distroSettings/tabs/GeneralTab/getFormSchema.ts +++ b/apps/spruce/src/pages/distroSettings/tabs/GeneralTab/getFormSchema.ts @@ -135,8 +135,7 @@ export const getFormSchema = ( }, warningNote: { "ui:rows": 2, - // TODO: https://jira.mongodb.org/browse/DEVPROD-6656 - Swap this to textarea when the backend supports it - "ui:widget": "hidden", + "ui:widget": "textarea", "ui:description": "This will be displayed to users when selecting this distro as part of evergreen yml validation.", },