diff --git a/apps/parsley/src/App.tsx b/apps/parsley/src/App.tsx index 2b0fdfc2f..f2ee19db9 100644 --- a/apps/parsley/src/App.tsx +++ b/apps/parsley/src/App.tsx @@ -6,6 +6,7 @@ import routes from "constants/routes"; import { GlobalProviders } from "context"; import Content from "pages"; import { Login } from "pages/Login"; +import { isDevelopmentBuild } from "utils/environmentVariables"; const App = () => ( @@ -14,7 +15,9 @@ const App = () => ( - } path={routes.login} /> + {isDevelopmentBuild() && ( + } path={routes.login} /> + )} } path="/*" /> diff --git a/apps/spruce/src/App.tsx b/apps/spruce/src/App.tsx index b8a8aa6ba..b85ec32f0 100644 --- a/apps/spruce/src/App.tsx +++ b/apps/spruce/src/App.tsx @@ -12,11 +12,14 @@ import { routes } from "constants/routes"; import { ContextProviders } from "context/Providers"; import GQLWrapper from "gql/GQLWrapper"; import { Login } from "pages/Login"; +import { isDevelopmentBuild, isLocal } from "utils/environmentVariables"; const browserRouter = createBrowserRouter( createRoutesFromElements( <> - } /> + {(isDevelopmentBuild() || isLocal()) && ( + } /> + )} ; + component: NotFoundSvg, +} satisfies CustomMeta; -export const Default404: CustomStoryObj = { +export const Default404: CustomStoryObj = { render: () => (
- +
), }; diff --git a/apps/spruce/src/pages/404/NotFound.tsx b/apps/spruce/src/pages/404/NotFound.tsx index f3244d12d..49d2496be 100644 --- a/apps/spruce/src/pages/404/NotFound.tsx +++ b/apps/spruce/src/pages/404/NotFound.tsx @@ -1,7 +1,11 @@ -import notFound from "./notFound.svg"; +import { Suspense, lazy } from "react"; -const NotFound = () => ( - Page not found +const NotFoundSvg = lazy(() => import("./NotFoundSvg")); + +const NotFound: React.FC = () => ( + Loading}> + + ); export default NotFound; diff --git a/apps/spruce/src/pages/404/NotFoundSvg.tsx b/apps/spruce/src/pages/404/NotFoundSvg.tsx new file mode 100644 index 000000000..9e2e97d6c --- /dev/null +++ b/apps/spruce/src/pages/404/NotFoundSvg.tsx @@ -0,0 +1,13 @@ +import notFound from "./notFound.svg"; + +// It's not possible to lazy load an SVG, so we wrap the SVG in a React component. +const NotFoundSvg: React.FC = () => ( + Page not found +); + +export default NotFoundSvg; diff --git a/apps/spruce/src/pages/404/__snapshots__/NotFound_Default404.storyshot b/apps/spruce/src/pages/404/__snapshots__/NotFound_Default404.storyshot index ddb665b02..95d329825 100644 --- a/apps/spruce/src/pages/404/__snapshots__/NotFound_Default404.storyshot +++ b/apps/spruce/src/pages/404/__snapshots__/NotFound_Default404.storyshot @@ -6,6 +6,7 @@ alt="Page not found" data-cy="404" src="/src/pages/404/notFound.svg" + style="height: inherit; width: 100%; object-fit: cover;" /> \ No newline at end of file diff --git a/apps/spruce/src/utils/environmentVariables.ts b/apps/spruce/src/utils/environmentVariables.ts index 50bc173ad..b34ce1a89 100644 --- a/apps/spruce/src/utils/environmentVariables.ts +++ b/apps/spruce/src/utils/environmentVariables.ts @@ -48,6 +48,12 @@ export const isDevelopmentBuild: () => boolean = () => export const isProductionBuild = (): boolean => process.env.NODE_ENV === "production"; +/** + * `isLocal()` indicates if the current build is a local build. + * @returns `true` if the current build is a local build. + */ +export const isLocal = () => getReleaseStage() === "local"; + /** * `isBeta()` indicates if the current build is a build meant for a beta deployment. * @returns `true` if the current build is a beta build. diff --git a/apps/spruce/src/utils/request.ts b/apps/spruce/src/utils/request.ts index 620f8d87d..1e4a83618 100644 --- a/apps/spruce/src/utils/request.ts +++ b/apps/spruce/src/utils/request.ts @@ -1,9 +1,8 @@ -import { routes } from "constants/routes"; import { getUiUrl } from "./environmentVariables"; import { reportError } from "./errorReporting"; export const shouldLogoutAndRedirect = (statusCode: number) => - statusCode === 401 && window.location.pathname !== routes.login; + statusCode === 401; export const post = async (url: string, body: unknown) => { try {