This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
DEVPROD-3533: Add admin-only distro setting #2241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 flaky tests on run #15406 ↗︎
Details:
Review all test suite changes for PR #2241 ↗︎ |
||||||||||||||||||||
minnakt
approved these changes
Jan 29, 2024
| @@ -88,6 +93,10 @@ export const getFormSchema = ( | |||
| }, | |||
| distroOptions: { | |||
| "ui:ObjectFieldTemplate": CardFieldTemplate, | |||
| adminOnly: { | |||
| "ui:description": | |||
| "Admin-only distros are not selectable by general users (e.g. when spawning a host). They do not have their access controlled beyond being hidden.", | |||
There was a problem hiding this comment.
the example "when spawning a host" is somewhat confusing to me because I think we already hide distros in the spawn host modal through the userSpawnAllowed attribute. Unless maybe adminOnly is going to take precedence over userSpawnAllowed in the next PR? 👀 otherwise LGTM!
There was a problem hiding this comment.
Thomas clarified that there are lots of these temporary distros where userSpawnEnabled is true. The next PR will have admin-only take precedence over that setting, but will still allow these distros to be visible to admins in the dropdown.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-3533
Description
Screenshots
Testing
Evergreen PR
evergreen-ci/evergreen#7376