This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
EVG-21009: Make distro settings page readonly if user lacks edit permissions #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #13128 ↗︎
Details:
Review all test suite changes for PR #2086 ↗︎ |
|||||||||||||||
minnakt
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Is it intentional that the disabled form auto-collapses the expandable cards? It may give a mistaken impression that they are empty 🤔
There was a problem hiding this comment.
Yeah I think this was set up as such for project settings so that read-only repo settings wouldn't be as prominent on the page. Frankly I don't think it's a huge problem as the expandable card is decently obvious but we can revisit if we receive feedback on this!
| @@ -15,12 +21,22 @@ export const BaseTab = <T extends WritableDistroSettingsType>({ | |||
| initialFormState, | |||
| ...rest | |||
| }: BaseTabProps<T>) => { | |||
SupaJoon
approved these changes
Oct 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EVG-21009
Description
Screenshots
Disabled general settings page. You can see that the "New distro" button is omitted, and the delete button is disabled as well.
Existing functionality for a user who lacks view permissions:
