Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

EVG-19995: Use V11 Table Adapter #1882

Merged
merged 11 commits into from
Sep 6, 2023
Merged

EVG-19995: Use V11 Table Adapter #1882

merged 11 commits into from
Sep 6, 2023

Conversation

sophstad
Copy link
Contributor

@sophstad sophstad commented Jun 8, 2023

EVG-19995

Description

  • Use V11TableAdapter when possible to convert legacy tables
  • Sadly our Task Duration Table seemed to be too complex for the adapter 😢 I've left it out of this PR because it's a significant chunk of work. That means we can't get rid of the legacy table dependency yet, but it's ready for work at any time at EVG-20104.

Screenshots

Looks pretty much the same—
image

@sophstad sophstad requested a review from a team June 8, 2023 15:00
@sophstad sophstad marked this pull request as ready for review June 8, 2023 15:00
@cypress
Copy link

cypress bot commented Jun 8, 2023 •
edited
Loading

Passing run #12498 ↗︎

0 573 7 0 Flakiness 0

Details:

Oops, forgot hosts table
Project: Spruce Commit: bf1527b6f6
Status: Passed Duration: 17:10 💡
Started: Sep 6, 2023 6:44 PM Ended: Sep 6, 2023 7:01 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@sophstad sophstad removed the request for review from a team June 8, 2023 15:19
@sophstad sophstad marked this pull request as draft June 8, 2023 15:30
@sophstad
Copy link
Contributor Author

sophstad commented Jun 8, 2023

Cypress tests are failing due to LG-3313, I think we should wait until that's resolved.

@sophstad sophstad requested a review from a team September 5, 2023 21:32
@sophstad sophstad marked this pull request as ready for review September 5, 2023 21:32
khelif96
khelif96 approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@khelif96 khelif96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on this! Can't wait until we can fully migrate our tables and not have 3 different table deps :)

@sophstad sophstad added this pull request to the merge queue Sep 6, 2023
Merged via the queue into evergreen-ci:main with commit 55af81b Sep 6, 2023
2 checks passed
@sophstad sophstad deleted the EVG-19995 branch September 6, 2023 19:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@khelif96 khelif96 khelif96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophstad @khelif96