From d43ca82432a6eaa1819ce38be267733d6522a13d Mon Sep 17 00:00:00 2001
From: Zackary Santana <64446617+ZackarySantana@users.noreply.github.com>
Date: Thu, 29 Feb 2024 10:22:55 -0500
Subject: [PATCH] DEVPROD-4166 Add breaking commits option in previous commits
 dropdown (#2254)

---
 src/analytics/task/useTaskAnalytics.ts        |   4 +-
 src/gql/generated/types.ts                    |   2 +
 src/gql/queries/base-version-and-task.graphql |   1 +
 src/gql/queries/last-mainline-commit.graphql  |   1 +
 src/pages/task/ActionButtons.tsx              |   4 +-
 .../RelevantCommits.test.tsx}                 | 122 ++++++++++++++----
 .../index.tsx                                 |  59 +++++++--
 .../actionButtons/RelevantCommits/types.ts    |  16 +++
 .../utils.ts                                  |  14 +-
 .../actionButtons/previousCommits/types.ts    |   9 --
 10 files changed, 179 insertions(+), 53 deletions(-)
 rename src/pages/task/actionButtons/{previousCommits/PreviousCommits.test.tsx => RelevantCommits/RelevantCommits.test.tsx} (79%)
 rename src/pages/task/actionButtons/{previousCommits => RelevantCommits}/index.tsx (71%)
 create mode 100644 src/pages/task/actionButtons/RelevantCommits/types.ts
 rename src/pages/task/actionButtons/{previousCommits => RelevantCommits}/utils.ts (82%)
 delete mode 100644 src/pages/task/actionButtons/previousCommits/types.ts

diff --git a/src/analytics/task/useTaskAnalytics.ts b/src/analytics/task/useTaskAnalytics.ts
index 29011dd6d3..a68225c558 100644
--- a/src/analytics/task/useTaskAnalytics.ts
+++ b/src/analytics/task/useTaskAnalytics.ts
@@ -10,7 +10,7 @@ import {
 } from "gql/generated/types";
 import { TASK } from "gql/queries";
 import { useQueryParam } from "hooks/useQueryParam";
-import { CommitType } from "pages/task/actionButtons/previousCommits/types";
+import { CommitType } from "pages/task/actionButtons/RelevantCommits/types";
 import { RequiredQueryParams, LogTypes } from "types/task";
 
 type LogViewer = "raw" | "html" | "parsley";
@@ -70,7 +70,7 @@ type Action =
   | { name: "Click Last Failing Stepback Task Link" }
   | { name: "Click Previous Stepback Task Link" }
   | { name: "Click Next Stepback Task Link" }
-  | { name: "Submit Previous Commit Selector"; type: CommitType };
+  | { name: "Submit Relevant Commit Selector"; type: CommitType };
 
 export const useTaskAnalytics = () => {
   const { id } = useParams<{ id: string }>();
diff --git a/src/gql/generated/types.ts b/src/gql/generated/types.ts
index 1da6c84f44..bc6a8b8af2 100644
--- a/src/gql/generated/types.ts
+++ b/src/gql/generated/types.ts
@@ -5409,6 +5409,7 @@ export type BaseVersionAndTaskQuery = {
     execution: number;
     id: string;
     projectIdentifier?: string | null;
+    status: string;
     baseTask?: {
       __typename?: "Task";
       execution: number;
@@ -6173,6 +6174,7 @@ export type LastMainlineCommitQuery = {
             __typename?: "Task";
             execution: number;
             id: string;
+            order: number;
             status: string;
           } | null> | null;
         } | null> | null;
diff --git a/src/gql/queries/base-version-and-task.graphql b/src/gql/queries/base-version-and-task.graphql
index 3452491b5e..1371d48913 100644
--- a/src/gql/queries/base-version-and-task.graphql
+++ b/src/gql/queries/base-version-and-task.graphql
@@ -10,6 +10,7 @@ query BaseVersionAndTask($taskId: String!) {
     execution
     id
     projectIdentifier
+    status
     versionMetadata {
       baseVersion {
         id
diff --git a/src/gql/queries/last-mainline-commit.graphql b/src/gql/queries/last-mainline-commit.graphql
index ef6daa28ac..098e78d78f 100644
--- a/src/gql/queries/last-mainline-commit.graphql
+++ b/src/gql/queries/last-mainline-commit.graphql
@@ -18,6 +18,7 @@ query LastMainlineCommit(
           tasks {
             execution
             id
+            order
             status
           }
         }
diff --git a/src/pages/task/ActionButtons.tsx b/src/pages/task/ActionButtons.tsx
index 776fb9848b..48b7592925 100644
--- a/src/pages/task/ActionButtons.tsx
+++ b/src/pages/task/ActionButtons.tsx
@@ -38,7 +38,7 @@ import {
 import { useLGButtonRouterLink } from "hooks/useLGButtonRouterLink";
 import { useQueryParam } from "hooks/useQueryParam";
 import { TaskStatus } from "types/task";
-import { PreviousCommits } from "./actionButtons/previousCommits";
+import { RelevantCommits } from "./actionButtons/RelevantCommits";
 import { TaskNotificationModal } from "./actionButtons/TaskNotificationModal";
 
 interface Props {
@@ -254,7 +254,7 @@ export const ActionButtons: React.FC<Props> = ({
       <PageButtonRow>
         {!isExecutionTask && (
           <>
-            <PreviousCommits taskId={taskId} />
+            <RelevantCommits taskId={taskId} />
             <Button
               size="small"
               data-cy="task-history"
diff --git a/src/pages/task/actionButtons/previousCommits/PreviousCommits.test.tsx b/src/pages/task/actionButtons/RelevantCommits/RelevantCommits.test.tsx
similarity index 79%
rename from src/pages/task/actionButtons/previousCommits/PreviousCommits.test.tsx
rename to src/pages/task/actionButtons/RelevantCommits/RelevantCommits.test.tsx
index eeca443354..e47606ed0f 100644
--- a/src/pages/task/actionButtons/previousCommits/PreviousCommits.test.tsx
+++ b/src/pages/task/actionButtons/RelevantCommits/RelevantCommits.test.tsx
@@ -9,9 +9,9 @@ import {
 import { BASE_VERSION_AND_TASK, LAST_MAINLINE_COMMIT } from "gql/queries";
 import { renderWithRouterMatch, screen, userEvent, waitFor } from "test_utils";
 import { ApolloMock } from "types/gql";
-import { PreviousCommits } from ".";
+import { RelevantCommits } from ".";
 
-describe("previous commits", () => {
+describe("relevant commits", () => {
   // Patch and mainline commit behavior only have a significant difference when it comes to determining
   // the base or previous task. Patch gets the base task directly from BASE_VERSION_AND_TASK, while
   // mainline commits needs to run another query LAST_MAINLINE_COMMIT to get previous task.
@@ -19,13 +19,13 @@ describe("previous commits", () => {
     it("the button is disabled when there is no base task", async () => {
       const { Component } = RenderFakeToastContext(
         <MockedProvider mocks={[getPatchTaskWithNoBaseTask]}>
-          <PreviousCommits taskId="t1" />
+          <RelevantCommits taskId="t1" />
         </MockedProvider>,
       );
       renderWithRouterMatch(<Component />);
       await waitFor(() => {
         expect(
-          screen.getByRole("button", { name: "Previous commits" }),
+          screen.getByRole("button", { name: "Relevant commits" }),
         ).toHaveAttribute("aria-disabled", "true");
       });
     });
@@ -37,14 +37,14 @@ describe("previous commits", () => {
         <MockedProvider
           mocks={[getMainlineTaskWithBaseVersion, getNullParentTask]}
         >
-          <PreviousCommits taskId="t4" />
+          <RelevantCommits taskId="t4" />
         </MockedProvider>,
       );
       renderWithRouterMatch(<Component />);
 
       await waitFor(() => {
         expect(
-          screen.getByRole("button", { name: "Previous commits" }),
+          screen.getByRole("button", { name: "Relevant commits" }),
         ).toHaveAttribute("aria-disabled", "true");
       });
     });
@@ -54,14 +54,14 @@ describe("previous commits", () => {
         <MockedProvider
           mocks={[getMainlineTaskWithBaseVersion, getParentTaskWithError]}
         >
-          <PreviousCommits taskId="t4" />
+          <RelevantCommits taskId="t4" />
         </MockedProvider>,
       );
       renderWithRouterMatch(<Component />);
 
       await waitFor(() => {
         expect(
-          screen.getByRole("button", { name: "Previous commits" }),
+          screen.getByRole("button", { name: "Relevant commits" }),
         ).toHaveAttribute("aria-disabled", "true");
       });
     });
@@ -70,19 +70,19 @@ describe("previous commits", () => {
   it("the button is disabled when no base version exists", async () => {
     const { Component } = RenderFakeToastContext(
       <MockedProvider mocks={[getPatchTaskWithNoBaseVersion]}>
-        <PreviousCommits taskId="t3" />
+        <RelevantCommits taskId="t3" />
       </MockedProvider>,
     );
     renderWithRouterMatch(<Component />);
 
     await waitFor(() => {
       expect(
-        screen.getByRole("button", { name: "Previous commits" }),
+        screen.getByRole("button", { name: "Relevant commits" }),
       ).toHaveAttribute("aria-disabled", "true");
     });
   });
 
-  it("when base task is passing, all dropdown items generate the same link", async () => {
+  it("when base task is passing, last passing, base commit, and last executed dropdown items generate the same link and breaking commit is disabled", async () => {
     const user = userEvent.setup();
     const { Component } = RenderFakeToastContext(
       <MockedProvider
@@ -92,16 +92,16 @@ describe("previous commits", () => {
           getLastExecutedVersion,
         ]}
       >
-        <PreviousCommits taskId="t1" />
+        <RelevantCommits taskId="t1" />
       </MockedProvider>,
     );
     renderWithRouterMatch(<Component />);
 
-    await screen.findByRole("button", { name: "Previous commits" });
+    await screen.findByRole("button", { name: "Relevant commits" });
     expect(
-      screen.getByRole("button", { name: "Previous commits" }),
+      screen.getByRole("button", { name: "Relevant commits" }),
     ).toHaveAttribute("aria-disabled", "false");
-    await user.click(screen.getByRole("button", { name: "Previous commits" }));
+    await user.click(screen.getByRole("button", { name: "Relevant commits" }));
     await waitFor(() => {
       expect(screen.getByRole("menu")).toBeVisible();
     });
@@ -115,24 +115,31 @@ describe("previous commits", () => {
     expect(
       screen.getByRole("menuitem", { name: "Go to last executed version" }),
     ).toHaveAttribute("href", baseTaskHref);
+    expect(
+      screen.getByRole("menuitem", { name: "Go to breaking commit" }),
+    ).toHaveAttribute("aria-disabled", "true");
   });
 
-  it("when base task is failing, 'Go to base commit' and 'Go to last executed' dropdown items generate the same link and 'Go to last passing version' will be different.", async () => {
+  it("when base task is failing, 'Go to base commit' and 'Go to last executed' dropdown items generate the same link and 'Go to last passing version' will be different and 'Go to breaking commit' will be populated", async () => {
     const user = userEvent.setup();
     const { Component } = RenderFakeToastContext(
       <MockedProvider
-        mocks={[getPatchTaskWithFailingBaseTask, getLastPassingVersion]}
+        mocks={[
+          getPatchTaskWithFailingBaseTask,
+          getLastPassingVersion,
+          getBreakingCommit,
+        ]}
       >
-        <PreviousCommits taskId="t1" />
+        <RelevantCommits taskId="t1" />
       </MockedProvider>,
     );
     renderWithRouterMatch(<Component />);
 
-    await screen.findByRole("button", { name: "Previous commits" });
+    await screen.findByRole("button", { name: "Relevant commits" });
     expect(
-      screen.getByRole("button", { name: "Previous commits" }),
+      screen.getByRole("button", { name: "Relevant commits" }),
     ).toHaveAttribute("aria-disabled", "false");
-    await user.click(screen.getByRole("button", { name: "Previous commits" }));
+    await user.click(screen.getByRole("button", { name: "Relevant commits" }));
     await waitFor(() => {
       expect(screen.getByRole("menu")).toBeVisible();
     });
@@ -146,9 +153,12 @@ describe("previous commits", () => {
     expect(
       screen.getByRole("menuitem", { name: "Go to last executed version" }),
     ).toHaveAttribute("href", baseTaskHref);
+    expect(
+      screen.getByRole("menuitem", { name: "Go to breaking commit" }),
+    ).toHaveAttribute("href", "/task/breaking_commit");
   });
 
-  it("when base task is not in a finished state, the last executed & passing task is not the same as the base commit", async () => {
+  it("when base task is not in a finished state, the last executed, and passing task are not the same as the base commit and breaking commit is empty", async () => {
     const user = userEvent.setup();
     const { Component } = RenderFakeToastContext(
       <MockedProvider
@@ -156,18 +166,19 @@ describe("previous commits", () => {
           getPatchTaskWithRunningBaseTask,
           getLastPassingVersion,
           getLastExecutedVersion,
+          getBreakingCommit,
         ]}
       >
-        <PreviousCommits taskId="t3" />
+        <RelevantCommits taskId="t3" />
       </MockedProvider>,
     );
     renderWithRouterMatch(<Component />);
 
-    await screen.findByRole("button", { name: "Previous commits" });
+    await screen.findByRole("button", { name: "Relevant commits" });
     expect(
-      screen.getByRole("button", { name: "Previous commits" }),
+      screen.getByRole("button", { name: "Relevant commits" }),
     ).toHaveAttribute("aria-disabled", "false");
-    await user.click(screen.getByRole("button", { name: "Previous commits" }));
+    await user.click(screen.getByRole("button", { name: "Relevant commits" }));
     await waitFor(() => {
       expect(screen.getByRole("menu")).toBeVisible();
     });
@@ -181,6 +192,9 @@ describe("previous commits", () => {
     expect(
       screen.getByRole("menuitem", { name: "Go to last executed version" }),
     ).toHaveAttribute("href", "/task/last_executed_task");
+    expect(
+      screen.getByRole("menuitem", { name: "Go to breaking commit" }),
+    ).toHaveAttribute("aria-disabled", "true");
   });
 });
 
@@ -206,6 +220,7 @@ const getPatchTaskWithSuccessfulBaseTask: ApolloMock<
         displayName: "lint-agent",
         buildVariant: "lint",
         projectIdentifier: "evergreen",
+        status: "success",
         versionMetadata: {
           baseVersion: {
             id: "baseVersion",
@@ -246,6 +261,7 @@ const getPatchTaskWithRunningBaseTask: ApolloMock<
         displayName: "lint-agent",
         buildVariant: "lint",
         projectIdentifier: "evergreen",
+        status: "started",
         versionMetadata: {
           baseVersion: {
             id: "baseVersion",
@@ -286,6 +302,7 @@ const getPatchTaskWithFailingBaseTask: ApolloMock<
         displayName: "lint-agent",
         buildVariant: "lint",
         projectIdentifier: "evergreen",
+        status: "failed",
         versionMetadata: {
           baseVersion: {
             id: "baseVersion",
@@ -326,6 +343,7 @@ const getPatchTaskWithNoBaseVersion: ApolloMock<
         displayName: "lint-agent",
         buildVariant: "lint",
         projectIdentifier: "evergreen",
+        status: "success",
         versionMetadata: {
           baseVersion: null,
           id: "versionMetadataId",
@@ -339,6 +357,54 @@ const getPatchTaskWithNoBaseVersion: ApolloMock<
   },
 };
 
+const getBreakingCommit: ApolloMock<
+  LastMainlineCommitQuery,
+  LastMainlineCommitQueryVariables
+> = {
+  request: {
+    query: LAST_MAINLINE_COMMIT,
+    variables: {
+      projectIdentifier: "evergreen",
+      skipOrderNumber: 3676,
+      buildVariantOptions: {
+        tasks: ["^lint-agent$"],
+        variants: ["^lint$"],
+        statuses: ["failed"],
+      },
+    },
+  },
+  result: {
+    data: {
+      mainlineCommits: {
+        versions: [
+          {
+            version: {
+              id: "evergreen_44110b57c6977bf3557009193628c9389772163f2",
+              buildVariants: [
+                {
+                  tasks: [
+                    {
+                      id: "breaking_commit",
+                      execution: 0,
+                      order: 3676,
+                      status: "failed",
+                      __typename: "Task",
+                    },
+                  ],
+                  __typename: "GroupedBuildVariant",
+                },
+              ],
+              __typename: "Version",
+            },
+            __typename: "MainlineCommitVersion",
+          },
+        ],
+        __typename: "MainlineCommits",
+      },
+    },
+  },
+};
+
 const getLastPassingVersion: ApolloMock<
   LastMainlineCommitQuery,
   LastMainlineCommitQueryVariables
@@ -368,6 +434,7 @@ const getLastPassingVersion: ApolloMock<
                     {
                       id: "last_passing_task",
                       execution: 0,
+                      order: 3674,
                       status: "success",
                       __typename: "Task",
                     },
@@ -425,6 +492,7 @@ const getLastExecutedVersion: ApolloMock<
                     {
                       id: "last_executed_task",
                       execution: 0,
+                      order: 3676,
                       status: "failed",
                       __typename: "Task",
                     },
@@ -462,6 +530,7 @@ const getPatchTaskWithNoBaseTask: ApolloMock<
         displayName: "lint-agent",
         buildVariant: "lint",
         projectIdentifier: "evergreen",
+        status: "success",
         versionMetadata: {
           baseVersion: {
             id: "baseVersion",
@@ -498,6 +567,7 @@ const getMainlineTaskWithBaseVersion: ApolloMock<
         displayName: "lint-agent",
         buildVariant: "lint",
         projectIdentifier: "evergreen",
+        status: "success",
         versionMetadata: {
           baseVersion: {
             id: "baseVersion",
diff --git a/src/pages/task/actionButtons/previousCommits/index.tsx b/src/pages/task/actionButtons/RelevantCommits/index.tsx
similarity index 71%
rename from src/pages/task/actionButtons/previousCommits/index.tsx
rename to src/pages/task/actionButtons/RelevantCommits/index.tsx
index 00cba9d0b3..4311fbfda8 100644
--- a/src/pages/task/actionButtons/previousCommits/index.tsx
+++ b/src/pages/task/actionButtons/RelevantCommits/index.tsx
@@ -21,12 +21,12 @@ import { CommitType } from "./types";
 import { getLinks, getTaskFromMainlineCommitsQuery } from "./utils";
 
 const { applyStrictRegex } = string;
-const { isFinishedTaskStatus } = statuses;
+const { isFailedTaskStatus, isFinishedTaskStatus } = statuses;
 
-interface PreviousCommitsProps {
+interface RelevantCommitsProps {
   taskId: string;
 }
-export const PreviousCommits: React.FC<PreviousCommitsProps> = ({ taskId }) => {
+export const RelevantCommits: React.FC<RelevantCommitsProps> = ({ taskId }) => {
   const { sendEvent } = useTaskAnalytics();
   const dispatchToast = useToastContext();
 
@@ -42,6 +42,7 @@ export const PreviousCommits: React.FC<PreviousCommitsProps> = ({ taskId }) => {
     buildVariant,
     displayName,
     projectIdentifier,
+    status,
     versionMetadata,
   } = taskData?.task ?? {};
   const { order: skipOrderNumber } = versionMetadata?.baseVersion ?? {};
@@ -85,6 +86,30 @@ export const PreviousCommits: React.FC<PreviousCommitsProps> = ({ taskId }) => {
     },
   });
   const lastPassingTask = getTaskFromMainlineCommitsQuery(lastPassingTaskData);
+  const passingOrderNumber = lastPassingTask?.order;
+
+  // The breaking commit is the first failing commit after the last passing commit.
+  // The skip order number should be the last passing commit's order number + 1.
+  // We use + 2 because internally the query does a less than comparison.
+  // https://github.com/evergreen-ci/evergreen/blob/f6751ac3194452d457c0a6fe1a9f9b30dd674c60/model/version.go#L518
+  const { data: breakingTaskData, loading: breakingLoading } = useQuery<
+    LastMainlineCommitQuery,
+    LastMainlineCommitQueryVariables
+  >(LAST_MAINLINE_COMMIT, {
+    skip: !parentTask || !lastPassingTask || !isFailedTaskStatus(status),
+    variables: {
+      projectIdentifier,
+      skipOrderNumber: passingOrderNumber + 2,
+      buildVariantOptions: {
+        ...bvOptionsBase,
+        statuses: [TaskStatus.Failed],
+      },
+    },
+    onError: (err) => {
+      dispatchToast.error(`Breaking commit unavailable: '${err.message}'`);
+    },
+  });
+  const breakingTask = getTaskFromMainlineCommitsQuery(breakingTaskData);
 
   const { data: lastExecutedTaskData, loading: executedLoading } = useQuery<
     LastMainlineCommitQuery,
@@ -112,10 +137,11 @@ export const PreviousCommits: React.FC<PreviousCommitsProps> = ({ taskId }) => {
     () =>
       getLinks({
         parentTask,
+        breakingTask,
         lastPassingTask,
         lastExecutedTask,
       }),
-    [parentTask, lastPassingTask, lastExecutedTask],
+    [parentTask, breakingTask, lastPassingTask, lastExecutedTask],
   );
 
   const menuDisabled = !baseTask || !parentTask;
@@ -129,17 +155,17 @@ export const PreviousCommits: React.FC<PreviousCommitsProps> = ({ taskId }) => {
           rightGlyph={<Icon glyph="CaretDown" />}
           size={Size.Small}
         >
-          Previous commits
+          Relevant commits
         </Button>
       }
     >
-      No previous versions available.
+      No relevant versions available.
     </Tooltip>
   ) : (
     <Menu
       trigger={
         <Button rightGlyph={<Icon glyph="CaretDown" />} size={Size.Small}>
-          Previous commits
+          Relevant commits
         </Button>
       }
     >
@@ -148,7 +174,7 @@ export const PreviousCommits: React.FC<PreviousCommitsProps> = ({ taskId }) => {
         disabled={parentLoading}
         onClick={() =>
           sendEvent({
-            name: "Submit Previous Commit Selector",
+            name: "Submit Relevant Commit Selector",
             type: CommitType.Base,
           })
         }
@@ -156,12 +182,25 @@ export const PreviousCommits: React.FC<PreviousCommitsProps> = ({ taskId }) => {
       >
         Go to {versionMetadata?.isPatch ? "base" : "previous"} commit
       </MenuItem>
+      <MenuItem
+        as={Link}
+        disabled={breakingLoading || breakingTask === undefined}
+        onClick={() =>
+          sendEvent({
+            name: "Submit Relevant Commit Selector",
+            type: CommitType.Breaking,
+          })
+        }
+        to={linkObject[CommitType.Breaking]}
+      >
+        Go to breaking commit
+      </MenuItem>
       <MenuItem
         as={Link}
         disabled={passingLoading}
         onClick={() =>
           sendEvent({
-            name: "Submit Previous Commit Selector",
+            name: "Submit Relevant Commit Selector",
             type: CommitType.LastPassing,
           })
         }
@@ -174,7 +213,7 @@ export const PreviousCommits: React.FC<PreviousCommitsProps> = ({ taskId }) => {
         disabled={executedLoading}
         onClick={() =>
           sendEvent({
-            name: "Submit Previous Commit Selector",
+            name: "Submit Relevant Commit Selector",
             type: CommitType.LastExecuted,
           })
         }
diff --git a/src/pages/task/actionButtons/RelevantCommits/types.ts b/src/pages/task/actionButtons/RelevantCommits/types.ts
new file mode 100644
index 0000000000..15e5cce2a5
--- /dev/null
+++ b/src/pages/task/actionButtons/RelevantCommits/types.ts
@@ -0,0 +1,16 @@
+import {
+  BaseVersionAndTaskQuery,
+  LastMainlineCommitQuery,
+} from "gql/generated/types";
+
+export enum CommitType {
+  Base = "base",
+  LastPassing = "lastPassing",
+  Breaking = "breaking",
+  LastExecuted = "lastExecuted",
+}
+
+export type BaseTask = BaseVersionAndTaskQuery["task"]["baseTask"];
+
+export type CommitTask =
+  LastMainlineCommitQuery["mainlineCommits"]["versions"][number]["version"]["buildVariants"][number]["tasks"][number];
diff --git a/src/pages/task/actionButtons/previousCommits/utils.ts b/src/pages/task/actionButtons/RelevantCommits/utils.ts
similarity index 82%
rename from src/pages/task/actionButtons/previousCommits/utils.ts
rename to src/pages/task/actionButtons/RelevantCommits/utils.ts
index fa2b2510b3..a18f0770c3 100644
--- a/src/pages/task/actionButtons/previousCommits/utils.ts
+++ b/src/pages/task/actionButtons/RelevantCommits/utils.ts
@@ -1,23 +1,26 @@
 import { getTaskRoute } from "constants/routes";
 import { LastMainlineCommitQuery } from "gql/generated/types";
 import { reportError } from "utils/errorReporting";
-import { CommitTask, CommitType } from "./types";
+import { BaseTask, CommitTask, CommitType } from "./types";
 
 // a link cannot be null, so it's common to use # as a substitute.
 const nullLink = "#";
 
 export const getLinks = ({
+  breakingTask,
   lastExecutedTask,
   lastPassingTask,
   parentTask,
 }: {
-  lastExecutedTask: CommitTask;
-  lastPassingTask: CommitTask;
-  parentTask: CommitTask;
+  breakingTask: BaseTask;
+  lastExecutedTask: BaseTask;
+  lastPassingTask: BaseTask;
+  parentTask: BaseTask;
 }) => {
   if (!parentTask) {
     return {
       [CommitType.Base]: nullLink,
+      [CommitType.Breaking]: nullLink,
       [CommitType.LastPassing]: nullLink,
       [CommitType.LastExecuted]: nullLink,
     };
@@ -25,6 +28,9 @@ export const getLinks = ({
 
   return {
     [CommitType.Base]: getTaskRoute(parentTask.id),
+    [CommitType.Breaking]: breakingTask
+      ? getTaskRoute(breakingTask.id)
+      : nullLink,
     [CommitType.LastPassing]: getTaskRoute(
       lastPassingTask?.id || parentTask.id,
     ),
diff --git a/src/pages/task/actionButtons/previousCommits/types.ts b/src/pages/task/actionButtons/previousCommits/types.ts
deleted file mode 100644
index 2e1f5c629b..0000000000
--- a/src/pages/task/actionButtons/previousCommits/types.ts
+++ /dev/null
@@ -1,9 +0,0 @@
-import { BaseVersionAndTaskQuery } from "gql/generated/types";
-
-export enum CommitType {
-  Base = "base",
-  LastPassing = "lastPassing",
-  LastExecuted = "lastExecuted",
-}
-
-export type CommitTask = BaseVersionAndTaskQuery["task"]["baseTask"];