Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactiveSqlQueryRow expects boolean fields to be Int #100

Open
rrrship opened this issue Jan 8, 2024 · 1 comment
Open

ReactiveSqlQueryRow expects boolean fields to be Int #100

rrrship opened this issue Jan 8, 2024 · 1 comment

Comments

@rrrship
Copy link

rrrship commented Jan 8, 2024

When migrating from the non-reactive Eventuate stack to reactive, then all the examples and SQLs had the saga_instance fields as boolean, which means the reactive stack won't work as expected, because it expects these fields to be Integer, having 0 or 1 values.

Changing the getBoolean method to just handle boolean types fixed the issue. I can provide a PR if this change makes sense?

@cer
Copy link
Collaborator

cer commented Feb 21, 2024

Sorry for the delay. Yes, please provide a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants