Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pointless duplicate key detection should be removed #13

Open
dartartem opened this issue Apr 28, 2021 · 0 comments
Open

pointless duplicate key detection should be removed #13

dartartem opened this issue Apr 28, 2021 · 0 comments

Comments

@dartartem
Copy link
Contributor

dartartem commented Apr 28, 2021 •
edited
Loading

For example using http proxy to deliver events to customer service (https://github.com/eventuate-examples/eventuate-tram-reactive-examples-customers-and-orders):

Proxy does HTTP POST to Customer Service
Customer service successfully updates database etc.
Customer Service sends back an HTTP response
Proxy crashes before receiving the HTTP response and recording the duplicate.
Proxy recovers and redelivers what is now a duplicate.

This scenario shows that duplicate detection should be handled on application side and should be removed from proxy.
@dartartem dartartem changed the title pointless duplicate key detection pointless duplicate key detection should be removed Apr 28, 2021
@dartartem dartartem mentioned this issue Apr 28, 2021
Merged
dartartem added a commit to dartartem/eventuate-tram-messaging-http that referenced this issue May 12, 2021
@dartartem
eventuate-tram#13: pointless duplicate key detection should be remove…
5c2fa40 
…d. Removed database usage from proxy (except tests)
cer added a commit that referenced this issue Jun 15, 2021
@cer
Merge pull request #14 from dartartem/master
3d1896a 
#13: pointless duplicate key detection should be removed. Removed dat…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dartartem