Get public repo up-to-date with latest improvements #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disposing the consumer is not sufficient for cleanly disconnecting the consumer. From https://docs.confluent.io/clients-confluent-kafka-dotnet/current/overview.html#the-consume-loop: Note that disposing the consumer instance after you are finished using it (achieved with the using block in the above example) will ensure that active sockets are closed and internal state is cleaned up. In order to leave the group cleanly - i.e. commit final offsets and trigger a group rebalance which ensures that any partitions owned by the consumer are re-assigned to other members in the group in a timely fashion - you additionally need to call the Close method prior to disposing.
There is an issue with the latest cp-kafka docker image version 7.0.1 which prevents it from starting (see confluentinc/kafka-images#127). Pinning kafka and zookeeper images a version 7.0.0 for now.
We want to stop consumption and processing activities when the service host is shutting down.
Referencing Microsoft.Extensions.Hosting.Abstractions to get the IHostedService definition instead of Microsoft.AspNetCore. Eventuate Tram shouldn't need anything "web" specific
Cleanup references in solution
Rename Backpressure properties to be clearer
Fix c# naming conventions
US592494
US592494
Protect _consumers and _dispatchers against concurrent modifications from multiple threads
US566978
Add a changelog to document changes made in released versions
bzylstra
reviewed
Sep 20, 2023
IO.Eventuate.Tram.IntegrationTests/TestFixtures/PerformanceTests.cs
Outdated
Show resolved
Hide resolved
bzylstra
reviewed
Sep 20, 2023
IO.Eventuate.Tram.IntegrationTests/TestFixtures/ProducerConsumerIntegrationTests.cs
Show resolved
Hide resolved
bzylstra
reviewed
Sep 20, 2023
bzylstra
reviewed
Sep 20, 2023
bzylstra
reviewed
Sep 20, 2023
bzylstra
reviewed
Sep 20, 2023
bzylstra
reviewed
Sep 20, 2023
bzylstra
reviewed
Sep 20, 2023
bzylstra
reviewed
Sep 20, 2023
IO.Eventuate.Tram/Local/Kafka/Consumer/BackPressureManagerState.cs
Outdated
Show resolved
Hide resolved
bzylstra
reviewed
Sep 20, 2023
bzylstra
reviewed
Sep 20, 2023
bzylstra
requested changes
Sep 20, 2023
bzylstra
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.