Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically create Listable variations for types that aren't already Listable #58

Open
evaera opened this issue Jan 16, 2019 · 3 comments

Comments

@evaera
Copy link
Owner

evaera commented Jan 16, 2019

No description provided.

@LoganDark
Copy link
Contributor

This could open up many possibilities for 'variant' types.

@autonordev
Copy link
Collaborator

Would there be a chance of this causing problems for types that really shouldn't be listable. E.g. PlayerID can be expensive if enough players are specified, or in some commands (e.g. place players [place id]) it could be potentially problematic.

@evaera
Copy link
Owner Author

evaera commented Oct 24, 2019

Would there be a chance of this causing problems for types that really shouldn't be listable. E.g. PlayerID can be expensive if enough players are specified, or in some commands (e.g. place players [place id]) it could be potentially problematic.

No, I don't think so. This would create a plural type out of any singular types, so commands can still choose to use the singular variation if they wish which isn't listable. This change would only mean that if a type like "integer" is registered, it will automatically register "integers". But if you only wanted one integer, you could still use type "integer" in your command. So the control is still up to the developer here.

@autonordev autonordev added the breaking change Major change. label Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants