-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requirement to precisely pin the version of cargo-expand #90
Comments
AFAIK, to make the output from macrotest completely stable, some things need to be pinned, not only cargo-expand.
The most likely to affect the output would be prettyplease versions. If I understand correctly, what you actually encountered was due to the last one (probably the change in prettyplease 0.2.4). And in the first place, it is odd that the version of cargo-expand's prettyplease dependency is also important, even though macrotest calls it. In other words, if we had passed the |
Hmm. I tried to do this (master...taiki-e:macrotest:ugly), but cargo-expand applies some additional changes to the non- |
CI tests need to use pinned |
Assuming |
And the toolchain needs to be pinned. I'm not sure if we need to mention that. Those two things are what I'm doing in derive-deftly and it is, empirically, reliable. (And, empirically, updating toolchain, edition, pinned |
As for the editions, there was a problem due to the lack of support for the newer ones, and I guess that is what you were encountering (#82). And that has been fixed in today's release in such a way that similar problems will not occur in the future (hopefully). |
Yes, I did need to pick that up indeed (and yes, thanks for #82 which lgtm), but there were other changes too. Anyway, I'm on 2021 now, successfully, so thanks :-). |
macrotest
depends fundamentally on the stability of the output ofcargo expand
. But this is not something thatcargo expand
's maintainers promise: dtolnay/cargo-expand#179.If one is using
macrotest
in CI, as one should, the CI will occasionally need to rebuildcargo expand
. If it gets a new version, the tests break.The solution is to use something like
I think this should be documented.
The text was updated successfully, but these errors were encountered: