Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Rename agent_config to runtime_config #330

Open
yunwei37 opened this issue Aug 14, 2024 · 8 comments
Open

[FEATURE] Rename agent_config to runtime_config #330

yunwei37 opened this issue Aug 14, 2024 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@yunwei37
Copy link
Member

Is your feature request related to a problem? Please describe.

As time envolve, The agent config in https://github.com/eunomia-bpf/bpftime/blob/master/runtime/include/bpftime_config.hpp is no longer only for the agent. It should contain all the runtime config.

And also, the two config in

const char *run_with_kernel_env = getenv("BPFTIME_RUN_WITH_KERNEL");
should be merged into the runtime config data struct and init in
const agent_config bpftime::get_agent_config_from_env()

Describe the solution you'd like

  • Rename all agent_config to runtime_config.
  • Move the config in syscall-server to bpftime_config
@yunwei37 yunwei37 added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 14, 2024
@Officeyutong
Copy link
Contributor

Should we consider using configuration library like https://www.boost.org/doc/libs/1_85_0/libs/config/doc/html/index.html ?

Since it will be more convenient to manage and parse configuration from multiple sources

@yunwei37
Copy link
Member Author

It seems what you mentioned is not a config library, but how to config the boost library for different compiler/usecases

@yunwei37
Copy link
Member Author

Any recommendations for libraries?

@yunwei37
Copy link
Member Author

https://github.com/hyperrealm/libconfig maybe?

It seems our configurations are simple and don't need such libraries for management

@Officeyutong
Copy link
Contributor

Any recommendations for libraries?

Sorry, my fault, too sleepy now. Try libconfig

@Officeyutong
Copy link
Contributor

https://github.com/hyperrealm/libconfig maybe?

It seems our configurations are simple and don't need such libraries for management

Yes, this is what I would like to reocmmend. Though the configuration structure of bpftime is simple now, but it has a big chance to get more complicated in the future.

@yunwei37
Copy link
Member Author

yunwei37 commented Aug 14, 2024

it has a big chance to get more complicated in the future

well...what kinds of new configuration would bpftime have in the future? I'm not quite sure about that.

I would suggest that we focus on the small number of configurations we have now, and don't need a library to handle that

@Officeyutong
Copy link
Contributor

it has a big chance to get more complicated in the future

well...what kinds of new configuration would bpftime have in the future? I'm not quite sure about that.

I would suggest that we focus on the small number of configurations we have now, and don't need a library to handle that

Ok, let's focus on configurations now and don't adopt a config library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants