From eea3eef527a467a18f747e5cb4529dd500579c92 Mon Sep 17 00:00:00 2001 From: Teppei Shintani Date: Sun, 7 Jan 2024 16:59:19 +0900 Subject: [PATCH] Add packwerk to dependencies In the Gemfile, packwerk was specified, but this does not show that it depends on the packwerk gem when installed as a gem. Therefore, it is necessary to describe the dependencies of packwerk gem in gemspec as well. Note, however, that this gem depends on the implementation of the Pull Request, which is still under development, so it will not work with the latest version of packwerk. --- CHANGELOG.md | 2 ++ Gemfile | 2 +- Gemfile.lock | 1 + packwerk_yard.gemspec | 2 ++ 4 files changed, 6 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0631296..12b64a4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,7 @@ ## [Unreleased] +- Add packwerk to dependencies https://github.com/euglena1215/packwerk-yard/pull/6 + ## [0.1.0] - 2024-01-07 - Initial release diff --git a/Gemfile b/Gemfile index ea14755..44df0b2 100644 --- a/Gemfile +++ b/Gemfile @@ -5,7 +5,7 @@ source "https://rubygems.org" # Specify your gem's dependencies in packwerk_yard.gemspec gemspec -# TODO: Move to gemspec after merged https://github.com/Shopify/packwerk/pull/375 +# TODO: Remove this after merged https://github.com/Shopify/packwerk/pull/375 gem "packwerk", git: "https://github.com/richardmarbach/packwerk", branch: "configurable_parser_interface" gem "minitest" diff --git a/Gemfile.lock b/Gemfile.lock index 2fca968..4e92427 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -18,6 +18,7 @@ PATH remote: . specs: packwerk_yard (0.1.0) + packwerk parser yard diff --git a/packwerk_yard.gemspec b/packwerk_yard.gemspec index 5c05108..8da6477 100644 --- a/packwerk_yard.gemspec +++ b/packwerk_yard.gemspec @@ -34,4 +34,6 @@ Gem::Specification.new do |spec| spec.add_dependency("parser") spec.add_dependency("yard") + # TODO: Set minimum version of packwerk after merged https://github.com/Shopify/packwerk/pull/375 + spec.add_dependency("packwerk") end