Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PopSigner.Jwt to support unlock with biometrics or PIN #289

Open
babisRoutis opened this issue Jul 12, 2024 · 0 comments · May be fixed by #290
Open

Improve PopSigner.Jwt to support unlock with biometrics or PIN #289

babisRoutis opened this issue Jul 12, 2024 · 0 comments · May be fixed by #290
Labels
feature New feature or request

Comments

@babisRoutis
Copy link
Contributor

babisRoutis commented Jul 12, 2024

Current implementation of PopSigner.Jwt although it uses JWSSigner from Nimbus,
it doesn't provide the ability to suspend signing in order to allow the user to authorize with biometrics or PIN the use of the Android Keystore.

The approach is explained here

  • Allow caller to provide a lamda for authorize the signature. This lamda should be part of the PopSigner.Jwt
  • Change JwtProofBuilder to suspend signature, execute the lamda and then resume signing.
@babisRoutis babisRoutis added the feature New feature or request label Jul 12, 2024
@babisRoutis babisRoutis linked a pull request Jul 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant