Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Issuance feature interactors tests #212

Merged
merged 12 commits into from
Oct 16, 2024
Merged

Test: Issuance feature interactors tests #212

merged 12 commits into from
Oct 16, 2024

Conversation

ckaitatzis
Copy link
Contributor

@ckaitatzis ckaitatzis commented Oct 16, 2024 •
edited
Loading

Description of changes

Unit tests provided for issuance feature module interactors.

Covering implementation of TestDocumentOfferInteractor, extra tests in TestAddDocumentInteractor covering call of buildGenericSuccessRouteForDeferred, mocked objects placed in TestsData in order to be reused when possible.

Addresses: #188

  • Test suite run successfully

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the readme
  • My changes generate no new warnings
  • I have added unit tests that prove existing features work
  • New and existing unit tests pass locally with my changes
  • I have checked that my views are accessible
  • I have checked that my strings are localized where applicable

ckaitatzis and others added 11 commits October 11, 2024 13:00
@ckaitatzis
Created TestDocumentOfferInteractor, providing tests for resolveDocum…
42c66ae 
…entOffer function

Signed-off-by: Christos Kaitatzis <[email protected]>
@ckaitatzis
Additional tests defined in TestDocumentOfferInteractor covering case…
c7e120f 
…s of issueDocuments function. TestApplication modified so as to initialize the application theme in order allow accessing theme colors called within the functions being tested.

Signed-off-by: Christos Kaitatzis <[email protected]>
@ckaitatzis
Merge branch 'main' into test/issuance_feature_interactors_unit_tests
ffb155f
@ckaitatzis
Extra tests in TestAddDocumentInteractor covering call of buildGeneri…
2147208 
…cSuccessRouteForDeferred, provided comments on test cases
@ckaitatzis
Merge branch 'main' into test/issuance_feature_interactors_unit_tests
71c126e
@ckaitatzis
Correction in comments of a test case
f29bb49
@gstamatop
Refactor: Make issuanceJob private in AddDocumentViewModel.
07490ef
@gstamatop
Refactor: Small corrections
4d2ff79
@ckaitatzis
Centrally defining mocked data where possible, mocked objects moved t…
9c5a49f 
…o TestsData in order to be reused
@stzouvaras
ThemeManager should not throw runtime exception if its not set, it sh…
65519d1 
…ould initialize it self with the default values. Only if someone wants to override the default values can take control with the builder outside the ThemeManager.
@stzouvaras
Merge branch 'main' into test/issuance_feature_interactors_unit_tests
9b721ec
@ckaitatzis ckaitatzis requested a review from a team as a code owner October 16, 2024 13:27
@stzouvaras stzouvaras merged commit 765e117 into eu-digital-identity-wallet:main Oct 16, 2024
2 checks passed
@stzouvaras stzouvaras deleted the test/issuance_feature_interactors_unit_tests branch October 16, 2024 17:37
@stzouvaras stzouvaras linked an issue Oct 17, 2024 that may be closed by this pull request
Interactors Unit Testing and Coverage #188
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stzouvaras stzouvaras stzouvaras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interactors Unit Testing and Coverage
3 participants
@ckaitatzis @stzouvaras @gstamatop