Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using latest value sets when running tests #90

Closed
dslmeinte opened this issue Dec 16, 2021 · 1 comment
Closed

Consider using latest value sets when running tests #90

dslmeinte opened this issue Dec 16, 2021 · 1 comment

Comments

@dslmeinte
Copy link
Collaborator

The tests currently specify all external data, including the “compressed” value sets, themselves. That prevents the tests from failing when a value set would change in an incompatible way, which would be good to know. To improve on that, we could do either one of the following:

  1. Use the latest value sets when evaluating, injecting that into the external part of the rules' logic expressions' input data. That means that the corresponding part of the rules' tests can be removed, mostly leaving validationClock.
  2. Keep the value sets specified in the rules' tests, but run the tests a second time with the latest value sets overwriting the specified one.
@dslmeinte
Copy link
Collaborator Author

(see #98)

@dslmeinte dslmeinte closed this as not planned Won't fix, can't repro, duplicate, stale Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant