Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for pydantic-settings in Configuration.from_pydantic() #768

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tsaryapkin
Copy link

  • Configuration provider can be initialised via from_pydantic method from both pydantic.BaseSettings (pydantic v1) and pydantic_settings.BaseSettings (based on pydantic v2).
  • I also specified flask and Werkzeug (used by flask) versions because the latest version of flask seems to be incompatible with the library and lots of tests failed.

@apollo17m
Copy link

Hey @tsaryapkin , @rmk135

@tsaryapkin Thanks a lot for this update, I'm currently blocked from using this lib with a new project because of this issue and this would help a lot.

@rmk135 Is it possible to review this PR soon ?

Thanks !

@martinkozle
Copy link

Hey @tsaryapkin , @rmk135

@tsaryapkin Thanks a lot for this update, I'm currently blocked from using this lib with a new project because of this issue and this would help a lot.

@rmk135 Is it possible to review this PR soon ?

Thanks !

I second this!

@zahycs
Copy link

zahycs commented Dec 18, 2023

Hi @rmk135

Any plans to merge this soon?

Thank you

@pow3rpi
Copy link

pow3rpi commented Jun 28, 2024

Hi @rmk135 @tsaryapkin,

Could you please review the changes and merge the updates if possible?
This issue needs to be solved)

@wordedword75049
Copy link

Hi @rmk135 @tsaryapkin,

Any plans on merging these updates in the latest future?
This issue also blocks me in my projects and this fix would help a lot

Thanks in advance!

@hoou
Copy link

hoou commented Oct 3, 2024

@wordedword75049 here are mentioned some workarounds that can potentially unblock you: #755

@naem1023
Copy link

@rmk135 Could someone review this PR that’s been sitting untouched for over a year?

@rmk135
Copy link
Member

rmk135 commented Nov 13, 2024

@naem1023 thanks for highlighting this. I started looking at the pydantic 2 support yesterday and came to a pretty similar idea on the implementation. This PR has already been implemented nicely (thanks to @tsaryapkin ).

However, we won't be able to merge it since there are a few merge conflicts. There have been a few changes made in the code since this PR was created. I'll see if I can resolve those conflicts myself or maybe will take the code to build a new branch and thank @tsariapkin for his contribution in the changelog and the contributors file.

@tsariapkin , if you have a moment to deal with the conflicts, that'd be much appreciated too. Otherwise, thanks for that contribution. Nicely done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants