Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support keystore and password file path flags in es-node #205

Open
qzhodl opened this issue Jan 29, 2024 · 2 comments
Open

Support keystore and password file path flags in es-node #205

qzhodl opened this issue Jan 29, 2024 · 2 comments
Assignees

Comments

@qzhodl
Copy link
Collaborator

qzhodl commented Jan 29, 2024

Rationale

Why should this feature exist?
Prysm have similar options like --wallet-dir and --wallet-password-file, and the related references are https://docs.prylabs.network/docs/prysm-usage/parameters and https://docs.prylabs.network/docs/wallet/deterministic

Implementation

Do you have ideas regarding the implementation of this feature?
Are you willing to implement this feature?

@syntrust
Copy link
Collaborator

syntrust commented May 29, 2024

Optimism:

  1. a remote signer (via opsigner.CLIConfig) or
  2. a mnemonic + derivation path or
  3. a private key.

reference:
https://github.com/ethereum-optimism/optimism/blob/be68885e45edda08deec735d1995f3500ad35b1b/op-service/crypto/signature.go#L46

Prysm:

  1. external-signer: URL for consensys' web3signer software to use with the Prysm validator client.
  2. wallet-dir + wallet-password-file

reference:
https://docs.prylabs.network/docs/prysm-usage/parameters#validator-flags

@qzhodl
Copy link
Collaborator Author

qzhodl commented Oct 29, 2024

Since Optimism doesn’t support the keystore either, we can deprioritize this issue.

@qzhodl qzhodl removed high priority enhancement New feature or request labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants