New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth_getFilterChanges has unclear input and return values #10

Open

digitaldonkey opened this issue Jul 12, 2018 · 0 comments

digitaldonkey commented Jul 12, 2018

I ran into some issues which seem important to be aware of when using the Schema with

eth_getFilterChanges": [["Q"], ["FilterChange"], 1],

Input "Q" is a different Q than others.

is IMHO not correct if you see Q as a 32byte padded number.
Q in this specific case is actually unpadded.

Return values are not correctly represented.

There are two different return types

Filter added with eth_newBlockFilter (block hashes) -> returns [D32]
eth_newPendingTransactionFilter (transaction hashes) -> returns [D32]
Filter added with eth_newFilter -> returns [FilterChange]

https://github.com/ethereum/wiki/wiki/JSON-RPC#returns-42

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment