Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added sending and estimating states to useEtherspotTransactions hook #86

Merged
merged 4 commits into from
Jan 30, 2024
Merged

added sending and estimating states to useEtherspotTransactions hook #86

merged 4 commits into from
Jan 30, 2024

Conversation

poocart
Copy link
Contributor

@poocart poocart commented Jan 30, 2024 •
edited
Loading

Description

  • Added isSending, isEstimating, containsSendingError, containsEstimatingError to useEtherspotTransactions hook

How Has This Been Tested?

  • Locally ran example dapp, integration tests to be updated.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

IAmKio
IAmKio previously approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment but it's not a showstopper

package.json Outdated Show resolved Hide resolved
@poocart poocart marked this pull request as ready for review January 30, 2024 11:49
IAmKio
IAmKio reviewed Jan 30, 2024
View reviewed changes
package.json Show resolved Hide resolved
IAmKio
IAmKio approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poocart poocart merged commit 7dcfea8 into master Jan 30, 2024
5 checks passed
@poocart poocart deleted the feature/use-etherspot-transactions-hook-send-states branch January 30, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IAmKio IAmKio IAmKio approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poocart @IAmKio