-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in FT8 Telemetry mode and an easy fix. (Atmel tool chain and possibly others) #18
Comments
Thank you very much, I will check this soon and push the change when I can verify the fix. |
I have the same problem with Arduino and bluepill too. in decoding the message with WSJT-X the last char of message is getting truncated. the SquirrelEng solution didn't work for me. |
I had the same problem. Plus another problem: Furthermore, there is much useless copying aroound array c18. -> This fixes the issues:
|
This fixes problems with FT8 HEX messages, as described in etherkit#18
There is a bug in the FT8 telemetry mode code.
In JTEncode.cpp line 887 the line: snprintf(temp_msg, 19, "%*s", 18, c18); sets temp_msg to a zero length string. This causes the variable "message" further down in the code to have a zero 1st byte and corrupts the telemetry message.
Replace the snprintf call with the following: snprintf(temp_msg, 19, "%18s", c18);
I am running the code on an Arduno Pro Mini (Atmel chip) and it appears that the %*s formatter is not functioning correctly on this tool chain. Since the length is hard coded, the simpler %18s will work.
73s de KJ6FO
The text was updated successfully, but these errors were encountered: