-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make json improvements #3496
Comments
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What feature should we add?
i am debugging an issue, and I had to log the json for the best results. what was annoying, is that I couldn't just turn on websockets debugging with their WEBSOCKETS_MAX_LOG_SIZE env variable, because web3.py is sending binary so it's log messages , so I decided to take a look.
for reference this is what logging in websockets looks like when you send in bytes instead of a str.
While looking around I found some room for improvement, happy to help if you think any of this is something you'd consider.
cls
be passed to the recursive errors/encode calls?if any of this stuff is of interest for this project, I'm happy to submit a PR.
The text was updated successfully, but these errors were encountered: