New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling the API 'deactivatePlugin' didn't deactivate it #342

Open

yann300 opened this issue Mar 8, 2021 · 2 comments

Assignees

Collaborator

yann300 commented Mar 8, 2021

Here's the line that had to be changed in remix-ide.
https://github.com/ethereum/remix-project/pull/946/files#diff-2ad69d48cacf44d289764525138962e8fc1d8d66b25606f6407930a3cdb7cd61L41
(calling the 'activatePlugin' seemed to work)

yann300 assigned bunsenstraat

yann300 added the bug label

bunsenstraat removed the bug label

Collaborator

bunsenstraat commented Mar 10, 2021

remixd can't call candeactivate on itself. that's the reason, it times out, but why is not clear. it's a websocket plugin.

Collaborator Author

yann300 commented Mar 10, 2021

good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment