Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme update #309

Open
LianaHus opened this issue Jan 12, 2021 · 0 comments
Open

theme update #309

LianaHus opened this issue Jan 12, 2021 · 0 comments
Assignees

Comments

@LianaHus
Copy link
Collaborator

LianaHus commented Jan 12, 2021

https://github.com/ethereum/remix-plugin/blob/master/packages/api/src/lib/theme/types.ts#L1

  • disabledContrast should be added to the themes interface

  • name should be added to the themes interface

  • preferably leave quality instead of brightness. dark/light indicating that background color type and the brightness has a different meaning. the dark theme can still be bright and the light one be not.

Screenshot from 2021-01-12 13-46-32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants