Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler API not consistent #302

Open
yann300 opened this issue Dec 24, 2020 · 5 comments
Open

Compiler API not consistent #302

yann300 opened this issue Dec 24, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@yann300
Copy link
Collaborator

yann300 commented Dec 24, 2020

The common API from remix-plugins-directory has been removed but the api in remix-plugin still contain an old version.

https://github.com/ethereum/remix-plugins-directory/pull/190/files#diff-cec70245b5c97601abf594a1408261a57dfb0efd0fcd6e5f636b015072f2026fL15

We should check that all the new API added in remix-plugins-directory is reflected in remix-project repo

@yann300 yann300 added the bug Something isn't working label Dec 24, 2020
@bunsenstraat
Copy link
Collaborator

@yann300
I'm not sure what to do with storage, provider and wallet. Are they to be part of the IRemixApi? do they need a profile in remixApi? they are not plugins.. don't have methods except for provider.

@yann300
Copy link
Collaborator Author

yann300 commented Jan 15, 2021

  • storage is not defined, thought dgit could be implementing a minimal api that will cover storage
  • provider has only afaik the async function (it already exists in remix-ide)
  • wallet should have all the signing api. basically wallet is a subset of web3 provider (which only contains functions for signing) -- to be discussed..

@bunsenstraat
Copy link
Collaborator

The thing is the API doesn't expose any interface at this point that is not directly related to a plugin through a profile. So for the provider: what should be exposed in the IDE?

@yann300
Copy link
Collaborator Author

yann300 commented Jan 18, 2021

for the web3 provider, sendAsync is enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants
@bunsenstraat @yann300 and others