Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L2 revamp #14251

Open
wants to merge 143 commits into
base: dev
Choose a base branch
from
Open

L2 revamp #14251

wants to merge 143 commits into from

Conversation

corwintines
Copy link
Member

@corwintines corwintines commented Oct 29, 2024

Description

L2 hub
L2 learn
L2 networks
Find walletes

Related Issue

fixes #13062

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @corwintines! 🎉 Lot of work done in this PR.

src/intl/en/page-layer-2.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/styles/semantic-tokens.css Outdated Show resolved Hide resolved
<div className="m-auto max-w-[992px] py-9">
<div className="flex flex-col gap-8 border border-body-light p-8 md:flex-row md:gap-14">
<div className="flex-1">
<div className="max-w-[224px]">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be a good opportunity to reuse some components that we have to also have better consistency. In the homepage, we are using the StatsBoxGrid and BigNumber.

If not, we are falling again on having a lot of similar looking components.

locale: Lang
}) => {
const randomL2s = layer2Data.sort(() => 0.5 - Math.random()).slice(0, 9)
const medianTxCost =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is causing a hydration issue. We should do this inside getStaticProps.

src/components/Layer2NetworksTable/NetworkUsageChart.tsx Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where this is coming from but there is a mismatch in the expected html
image

src/components/Callout.tsx Outdated Show resolved Hide resolved
src/components/icons/layer-2/MaturingIcon.tsx Outdated Show resolved Hide resolved
public/images/layer-2/linea.png Outdated Show resolved Hide resolved
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some initial thoughts... over all this looks fantastic, great job!

src/pages/layer-2/networks.tsx Outdated Show resolved Hide resolved
src/pages/layer-2/index.tsx Show resolved Hide resolved
src/pages/layer-2/index.tsx Outdated Show resolved Hide resolved
src/pages/layer-2/index.tsx Outdated Show resolved Hide resolved
className="flex w-full flex-col gap-16 px-8 py-8 md:flex-row"
>
<Callout
image={ExploreImage}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

This image gets cut off

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we're reusing this from the /networks/ hero.. I wonder if we have another option that isn't chopped at the top

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not that its cut off, its just how that image is. I think we could pick another image if we want, ill bring it up with Jakub.

src/intl/en/page-layer-2-learn.json Outdated Show resolved Hide resolved
src/intl/en/page-layer-2-learn.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits dependencies 📦 Changes related to project dependencies tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rethinking L2 information on ethereum.org
3 participants