-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L2 revamp #14251
base: dev
Are you sure you want to change the base?
L2 revamp #14251
Conversation
Co-authored-by: Paul Wackerow <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @corwintines! 🎉 Lot of work done in this PR.
<div className="m-auto max-w-[992px] py-9"> | ||
<div className="flex flex-col gap-8 border border-body-light p-8 md:flex-row md:gap-14"> | ||
<div className="flex-1"> | ||
<div className="max-w-[224px]"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be a good opportunity to reuse some components that we have to also have better consistency. In the homepage, we are using the StatsBoxGrid
and BigNumber
.
If not, we are falling again on having a lot of similar looking components.
locale: Lang | ||
}) => { | ||
const randomL2s = layer2Data.sort(() => 0.5 - Math.random()).slice(0, 9) | ||
const medianTxCost = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is causing a hydration issue. We should do this inside getStaticProps
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some initial thoughts... over all this looks fantastic, great job!
className="flex w-full flex-col gap-16 px-8 py-8 md:flex-row" | ||
> | ||
<Callout | ||
image={ExploreImage} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see we're reusing this from the /networks/ hero.. I wonder if we have another option that isn't chopped at the top
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its not that its cut off, its just how that image is. I think we could pick another image if we want, ill bring it up with Jakub.
Co-authored-by: Paul Wackerow <[email protected]>
Co-authored-by: Paul Wackerow <[email protected]>
Co-authored-by: Pablo Pettinari <[email protected]>
Co-authored-by: Pablo Pettinari <[email protected]>
Description
L2 hub
L2 learn
L2 networks
Find walletes
Related Issue
fixes #13062