-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: quiz template config #14208
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
content 🖋️
This involves copy additions or edits
tooling 🔧
Changes related to tooling of the project
translation 🌍
This is related to our Translation Program
labels
Oct 21, 2024
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wackerow
commented
Oct 21, 2024
* - "what-is-ethereum-1-d-label" | ||
* - "what-is-ethereum-1-d-explanation" | ||
*/ | ||
const questionBankConfig: QuestionBankConfig = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 Start here for the core of proposed changes
wackerow
requested review from
corwintines,
pettinarip and
minimalsm
as code owners
October 21, 2024 21:31
"All of the options provide ways to own digital assets on Ethereum. Tokens, NFTs, and ENS are all ways to represent ownership of digital assets."
corwintines
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
content 🖋️
This involves copy additions or edits
tooling 🔧
Changes related to tooling of the project
translation 🌍
This is related to our Translation Program
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targers branch:
rename-quiz-keys
Description
questionBank
logic to use a simplifiedquestionBankConfig
object, which seeds thequestionBank
object needed for the front endExample
Inside
const questionBankConfig: QuestionBankConfig
fromsrc/data/quizzes/questionBank.ts
:This will be parsed into the following before being exported as part of
questionBank
:Separately, these strings must be added to the
en/learn-quizzes.json
file for each question:some-quiz-topic-${questionNumberForTopic}-prompt
some-quiz-topic-${questionNumberForTopic}-${answerChoiceLetter}-label
(for each answer choice)some-quiz-topic-${questionNumberForTopic}-${answerChoiceLetter}-explanation
(for each answer choice)Related Issue
Ongoing Quiz improvement efforts