Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate ApplyNow Components to shadcn/Tailwind #14046

Merged
merged 5 commits into from
Oct 10, 2024
Merged

Migrate ApplyNow Components to shadcn/Tailwind #14046

merged 5 commits into from
Oct 10, 2024

Conversation

0xgun
Copy link
Contributor

@0xgun 0xgun commented Oct 3, 2024 •
edited by pettinarip
Loading

DEPENDS on #14043

Description

Related Issue

#13946

@netlify Netlify
Copy link

netlify bot commented Oct 3, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 20d3f86
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6708137ad2db7d0008275b47
😎 Deploy Preview https://deploy-preview-14046--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 50 (🔴 down 3 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pettinarip pettinarip mentioned this pull request Oct 4, 2024
Open
65 tasks
pettinarip
pettinarip requested changes Oct 4, 2024
View reviewed changes
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xgun left one question. The rest looks good.

Seems that this PR was branched off #14043. Will mark it as blocked until that one gets merged.

src/components/Translatathon/ApplyNow.tsx Outdated Show resolved Hide resolved
src/components/Translatathon/ApplyNow.tsx Outdated Show resolved Hide resolved
@pettinarip pettinarip added the Status: Blocked 🛑 This is blocked label Oct 4, 2024
@0xgun
Copy link
Contributor Author

0xgun commented Oct 4, 2024

@0xgun left one question. The rest looks good.

Seems that this PR was branched off #14043. Will mark it as blocked until that one gets merged.

@pettinarip pushed the changes

pettinarip
pettinarip requested changes Oct 9, 2024
View reviewed changes
Copy link
Member

@pettinarip pettinarip left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xgun left one last thing.

src/components/Translatathon/ApplyNow.tsx Outdated Show resolved Hide resolved
@0xgun 0xgun requested a review from pettinarip October 10, 2024 17:59
@pettinarip pettinarip merged commit 21748e3 into ethereum:dev Oct 10, 2024
9 of 10 checks passed
@pettinarip pettinarip added hacktoberfest Track hacktoberfest activity and removed Status: Blocked 🛑 This is blocked labels Oct 17, 2024
This was referenced Oct 23, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pettinarip pettinarip pettinarip approved these changes

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees
No one assigned
Labels
hacktoberfest Track hacktoberfest activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xgun @pettinarip